* [PATCH] staging: fsl-dpaa2: ethsw: Fix parenthesis alignment
@ 2020-04-02 2:33 John B. Wyatt IV
2020-04-03 8:30 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: John B. Wyatt IV @ 2020-04-02 2:33 UTC (permalink / raw)
To: outreachy-kernel, Ioana Radulescu, Ioana Ciornei,
Greg Kroah-Hartman, linux-kernel, devel
Cc: John B. Wyatt IV
Fix 2 parenthesis alignment issues.
Reported by checkpatch.
Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
---
drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
index 676d1ad1b50d..546ad376df99 100644
--- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
+++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
@@ -1094,7 +1094,8 @@ static int swdev_port_obj_del(struct net_device *netdev,
static int
ethsw_switchdev_port_attr_set_event(struct net_device *netdev,
- struct switchdev_notifier_port_attr_info *port_attr_info)
+ struct switchdev_notifier_port_attr_info
+ *port_attr_info)
{
int err;
@@ -1277,7 +1278,8 @@ static int port_switchdev_event(struct notifier_block *unused,
static int
ethsw_switchdev_port_obj_event(unsigned long event, struct net_device *netdev,
- struct switchdev_notifier_port_obj_info *port_obj_info)
+ struct switchdev_notifier_port_obj_info
+ *port_obj_info)
{
int err = -EOPNOTSUPP;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: fsl-dpaa2: ethsw: Fix parenthesis alignment
2020-04-02 2:33 [PATCH] staging: fsl-dpaa2: ethsw: Fix parenthesis alignment John B. Wyatt IV
@ 2020-04-03 8:30 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2020-04-03 8:30 UTC (permalink / raw)
To: John B. Wyatt IV
Cc: outreachy-kernel, Ioana Radulescu, Ioana Ciornei,
Greg Kroah-Hartman, linux-kernel, devel
On Wed, Apr 01, 2020 at 07:33:10PM -0700, John B. Wyatt IV wrote:
> Fix 2 parenthesis alignment issues.
>
> Reported by checkpatch.
>
> Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
> ---
> drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
> index 676d1ad1b50d..546ad376df99 100644
> --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
> +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
> @@ -1094,7 +1094,8 @@ static int swdev_port_obj_del(struct net_device *netdev,
>
> static int
> ethsw_switchdev_port_attr_set_event(struct net_device *netdev,
> - struct switchdev_notifier_port_attr_info *port_attr_info)
> + struct switchdev_notifier_port_attr_info
> + *port_attr_info)
I feel like the end result is worse than the original code because of
how the type and the parameter name are on different lines. Sorry. :/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-03 8:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-02 2:33 [PATCH] staging: fsl-dpaa2: ethsw: Fix parenthesis alignment John B. Wyatt IV
2020-04-03 8:30 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox