From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78927C2D0E8 for ; Fri, 3 Apr 2020 11:01:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58F1D2073B for ; Fri, 3 Apr 2020 11:01:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390626AbgDCLBb (ORCPT ); Fri, 3 Apr 2020 07:01:31 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:38335 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727882AbgDCLBb (ORCPT ); Fri, 3 Apr 2020 07:01:31 -0400 Received: from mail.cetitecgmbh.com ([87.190.42.90]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MD5fd-1jSse22sxF-0097lj; Fri, 03 Apr 2020 13:01:15 +0200 Received: from pflvmailgateway.corp.cetitec.com (unknown [127.0.0.1]) by mail.cetitecgmbh.com (Postfix) with ESMTP id 924A7650C86; Fri, 3 Apr 2020 11:01:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at cetitec.com Received: from mail.cetitecgmbh.com ([127.0.0.1]) by pflvmailgateway.corp.cetitec.com (pflvmailgateway.corp.cetitec.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ub0epFD3L4KN; Fri, 3 Apr 2020 13:01:14 +0200 (CEST) Received: from pflmari.corp.cetitec.com (unknown [10.8.5.74]) by mail.cetitecgmbh.com (Postfix) with ESMTPSA id 358F8650C85; Fri, 3 Apr 2020 13:01:14 +0200 (CEST) Received: by pflmari.corp.cetitec.com (Postfix, from userid 1000) id CB397804FB; Fri, 3 Apr 2020 13:01:13 +0200 (CEST) Date: Fri, 3 Apr 2020 13:01:13 +0200 From: Alex Riesen To: Kieran Bingham Cc: Geert Uytterhoeven , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Rob Herring , Mark Rutland , Kuninori Morimoto , devel@driverdev.osuosl.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v5 1/9] media: adv748x: fix end-of-line terminators in diagnostic statements Message-ID: <20200403110113.GC6164@pflmari> Mail-Followup-To: Alex Riesen , Kieran Bingham , Geert Uytterhoeven , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Rob Herring , Mark Rutland , Kuninori Morimoto , devel@driverdev.osuosl.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <2f2460435afa594ef417e70068b125af97ddca39.1585852001.git.alexander.riesen@cetitec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:Bbg/sa2nebGInCOzRlxsf3+du+x+7dB7nk+MdMDlTbL83H08v/+ C9f3ILXi8lLdXtn5scD40ZkxYv1s2SuUikXF5mnVUDWwcctHbD8j3rC2XLQjQbG5FzgOZDa 1fpz7hPvw8Wz5OPtK9/qDMg2vn5JPI4jYIbM+isfetbiadK/P3D+80OV/4KOdIiamIxDZ3f l2KuoVrEsIqMDfeAIrJtw== X-UI-Out-Filterresults: notjunk:1;V03:K0:Jo27tFzgTiw=:hJzObOQGhiuAozTgjKzMTs zAq11WEmyc5MTzKkMXU7PTXxotGKw68UoueTMgJS6ydaG/1guyTtA5Ff/2pmDkWqT8jYkqKDA 3w92bV63COiQA6w+lc4lGZ1yAarXjUPZEAcP4W5zxH81SKpwtd63YptJi/k7ZlAKBpqdrVKtX iKmEU6eb1Cvc4lg9beV3Elm3N8RDzQGMYkvEitRzPcrbKlp+X/DeRl4nAfJPeMuJFBk7zIDhb 18DZFPWOdxBFU0lhcIHecz5grtc+n4u0LVBERwNT+iVRFfRXZfxekIst/TVqVrPVGnCF1+yZW JIjYpkQe33IqFm9XJvxWMMeOjppHAWxRU2UZJBlG+F9gMxYoMXHpdTIm/veuQHrVqnZzBh32e CXiFqG9ns1HUihI9CbTCrcep9Z77GRh2E8y8dtsjZdLIGIKuRBGGG95s96QayriXx3EKMvnKq 1uMjn3QbkUCQ+6vfJX/Hr4zwnz29ldNM2nnxxOw5nhu85YD3Yl3ypdl3m6Oko6NoLdSZFlCy5 4fenZLcXqxBh6HRn3LTq/cDaMZadRoXOzjDvAkaaovu6ZT4P3vZdhjr+EuAcfzjh3hIZ9bX+s ngOpOG7yaYxkyVOcUELMY6tmgmzvEy122lr48zIALsAggE3TtKHoKKUD1isBlprww+fV5ItfW mRm1KgDwir/fHYhzyXvFqmW5JXFBS8EZ5+8wbdR+b0zFXzEXSSTX6kDmrI3AQO8AKtSO6Mqvq JqDuygHdgDsYCKl7JXcJ1l4Qwi7V+dUN7WyxlX//GkM7268dd0eb4VjLuKcTkDii0r0hS33+h 63VXMcM/E4vcE6Y42h8Ih9PKz356a8xgnDrSvjCS1SUwydV+K/2dCiXRiWKmC62OkWfNunb Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kieran Bingham, Fri, Apr 03, 2020 12:43:38 +0200: > Hi Alex, > > On 02/04/2020 19:34, Alex Riesen wrote: > > Signed-off-by: Alexander Riesen > > Reviewed-by: Laurent Pinchart > > I guess we could have also added this directly to the helper macros, but > there is indeed already a mixed usage so either way would require fixups > to be consistent. > > So this is a good option ;-) Not in this particular driver (unless I missed it), but yes, this was my main motivation. Also size of unrelated changes in the patch series and I prefer to have the ability to format diagnostics sequentially (also used it this time, only removed the debugging traces later). > Reviewed-by: Kieran Bingham Thanks!