Re: [PATCH] arm64: dts: qcom: sc7180: Changed polling-delay in Thermal-zones node

[Matthias Kaehlcke <mka@chromium.org>]

Hi Rajeshwari,

do you plan to send v2 with an updated commit message?

Thanks

Matthias

On Wed, Mar 18, 2020 at 02:40:47PM +0530, Amit Kucheria wrote:
> On Wed, Mar 18, 2020 at 11:49 AM Rajeshwari Ravindra Kamble (Temp)
> <rkambl@codeaurora.org> wrote:
> >
> >
> > On 3/17/2020 10:20 PM, Doug Anderson wrote:
> >
> > Hi,
> >
> > On Tue, Mar 17, 2020 at 12:42 AM Rajeshwari <rkambl@codeaurora.org> wrote:
> >
> > Changed polling-delay and polling-delay-passive to zero as per
> > the requirement.
> >
> > Signed-off-by: Rajeshwari <rkambl@codeaurora.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sc7180.dtsi | 100 +++++++++++++++++------------------
> >  1 file changed, 50 insertions(+), 50 deletions(-)
> >
> > It probably wouldn't hurt to mention in the commit message that this
> > is because the thermal sensor interrupts are all hooked up and thus
> > the polling is not a useful thing to do.  ...but other than that:
> >
> > Reviewed-by: Douglas Anderson <dianders@chromium.org>
> >
> >
> > Hi Douglas
> >
> > I didn't  get your comment.
> >
> > Thanks,
> > Rajeshwari
> 
> I think he means that you haven't mentioned WHY this patch is needed
> in the message. The reason you should mention is "to disable polling
> mode of the framework since interrupts for tsens are already
> configured."
> 
> Regards,
> Amit