From: Rob Herring <robh@kernel.org>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: linux-clk@vger.kernel.org, dinguyen@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org,
mark.rutland@arm.com
Subject: Re: [PATCHv5 4/5] dt-bindings: documentation: add clock bindings information for Agilex
Date: Sat, 4 Apr 2020 11:01:04 -0600 [thread overview]
Message-ID: <20200404170104.GA25196@bogus> (raw)
In-Reply-To: <20200403235403.13990-5-dinguyen@kernel.org>
On Fri, 3 Apr 2020 18:54:02 -0500, Dinh Nguyen wrote:
> Document the Agilex clock bindings, and add the clock header file. The
> clock header is an enumeration of all the different clocks on the Agilex
> platform.
>
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> ---
> v5: update license to GPL-2.0-only
> Add additionalProperties
> Add clock input for clkmgr
> v4: really fix build error(comment formatting was wrong)
> v3: address comments from Stephen Boyd
> fix build error(tab removed in line 37)
> renamed to intel,agilex.yaml
> v2: convert original document to YAML
> ---
> .../bindings/clock/intel,agilex.yaml | 40 +++++++++++
> include/dt-bindings/clock/agilex-clock.h | 70 +++++++++++++++++++
> 2 files changed, 110 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/intel,agilex.yaml
> create mode 100644 include/dt-bindings/clock/agilex-clock.h
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/intel,agilex.example.dt.yaml: clock-controller@ffd10000: 'clocks', 'reg' do not match any of the regexes: 'pinctrl-[0-9]+'
See https://patchwork.ozlabs.org/patch/1266287
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-04-04 17:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 23:53 [PATCHv5 0/5] clk: agilex: add clock driver Dinh Nguyen
2020-04-03 23:53 ` [PATCHv5 1/5] clk: socfpga: stratix10: use new parent data scheme Dinh Nguyen
2020-04-03 23:54 ` [PATCHv5 2/5] clk: socfpga: remove clk_ops enable/disable methods Dinh Nguyen
2020-04-03 23:54 ` [PATCHv5 3/5] clk: socfpga: add const to _ops data structures Dinh Nguyen
2020-04-03 23:54 ` [PATCHv5 4/5] dt-bindings: documentation: add clock bindings information for Agilex Dinh Nguyen
2020-04-04 17:01 ` Rob Herring [this message]
2020-04-03 23:54 ` [PATCHv5 5/5] clk: socfpga: agilex: add clock driver for the Agilex platform Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200404170104.GA25196@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox