From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55255C2BA15 for ; Sat, 4 Apr 2020 15:40:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FFB820644 for ; Sat, 4 Apr 2020 15:40:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726373AbgDDPkR (ORCPT ); Sat, 4 Apr 2020 11:40:17 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:38642 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726197AbgDDPkQ (ORCPT ); Sat, 4 Apr 2020 11:40:16 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:b93f:9fae:b276:a89a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 1971E2931D2; Sat, 4 Apr 2020 16:40:15 +0100 (BST) Date: Sat, 4 Apr 2020 17:40:12 +0200 From: Boris Brezillon To: Guenter Roeck Cc: Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Boris Brezillon Subject: Re: [PATCH] mtd: spi-nor: Compile files in controllers/ directory Message-ID: <20200404174012.6d205fbc@collabora.com> In-Reply-To: <20200404153631.103549-1-linux@roeck-us.net> References: <20200404153631.103549-1-linux@roeck-us.net> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 4 Apr 2020 08:36:31 -0700 Guenter Roeck wrote: > Commit a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code > split") moved various files into a new directory, but did not add the new > directory to its parent directory Makefile. The moved files no longer > build, and affected flash chips no longer instantiate. > > Adding the new directory to the parent directory Makefile fixes the > problem. > > Fixes: a0900d0195d2 ("mtd: spi-nor: Prepare core / manufacturer code split") > Cc: Boris Brezillon > Cc: Tudor Ambarus > Signed-off-by: Guenter Roeck Reviewed-by: Boris Brezillon Thanks for the fix, and my apologies for the regression. > --- > drivers/mtd/spi-nor/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/spi-nor/Makefile b/drivers/mtd/spi-nor/Makefile > index 7ddb742de1fe..653923896205 100644 > --- a/drivers/mtd/spi-nor/Makefile > +++ b/drivers/mtd/spi-nor/Makefile > @@ -18,3 +18,5 @@ spi-nor-objs += winbond.o > spi-nor-objs += xilinx.o > spi-nor-objs += xmc.o > obj-$(CONFIG_MTD_SPI_NOR) += spi-nor.o > + > +obj-$(CONFIG_MTD_SPI_NOR) += controllers/