From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FC3EC2BA15 for ; Sat, 4 Apr 2020 16:46:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E16BC206F8 for ; Sat, 4 Apr 2020 16:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586018790; bh=YQG4A/GOYNd5Jp5QAvFtVV//iwhK5hZrHteGmAX+ZTI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=XxdEnmB12v++c1+XQ69ZDV/c1JKv53e6Mz4MM1ea9y9BRX/DeP54sAUhY6zcFHBhc bpz9w2gERmJEs5sHpGeZg7i7wUB5XsEt14BufCEKDTRN69TQcSOkoXvmDxsp+9xImx EQWYj03zYWn0qDBKvoqchEiIFjePsmrmrl8G5vFs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726312AbgDDQq3 (ORCPT ); Sat, 4 Apr 2020 12:46:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:55904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbgDDQq2 (ORCPT ); Sat, 4 Apr 2020 12:46:28 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 04114206D4; Sat, 4 Apr 2020 16:46:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586018788; bh=YQG4A/GOYNd5Jp5QAvFtVV//iwhK5hZrHteGmAX+ZTI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Chu2MnaGnccIKwDG6kMVXAqNdd6Up23J/BnZNgW1WTxLB+vGzeu/1vBFuH3d2Wmj7 IiRhxh4zmcsdEsCdrEvbHRbieYyKMuZxwYVXbpc65XAPVWIJiTU1LqoAUdFekAGqVI 79he8aXsBtMixMTbsEaeIcwT3gzoKlqJ8IPDlwQ0= Date: Sat, 4 Apr 2020 17:46:24 +0100 From: Jonathan Cameron To: Mircea Caprioru Cc: , , , , , Subject: Re: [PATCH] iio: core: Fix handling of 'dB' Message-ID: <20200404174624.0b7f1c80@archlinux> In-Reply-To: <20200401112230.4708-1-mircea.caprioru@analog.com> References: <20200401112230.4708-1-mircea.caprioru@analog.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 Apr 2020 14:22:30 +0300 Mircea Caprioru wrote: > This patch fixes the call to iio_str_to_fixpoint when using 'dB' sufix. > Before this the scale_db was not used when parsing the string written to > the attribute and it failed with invalid value. > > Fixes: b8528224741b ("iio: core: Handle 'dB' suffix in core") > Signed-off-by: Mircea Caprioru Gah, I guess this messed up around the introduction of the character handling. Applied to the fixes-togreg branch of iio.git. Thanks, Jonathan > --- > drivers/iio/industrialio-core.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c > index 157d95a24faa..7da9cd2a2b58 100644 > --- a/drivers/iio/industrialio-core.c > +++ b/drivers/iio/industrialio-core.c > @@ -909,14 +909,11 @@ static ssize_t iio_write_channel_info(struct device *dev, > return -EINVAL; > integer = ch; > } else { > - ret = iio_str_to_fixpoint(buf, fract_mult, &integer, &fract); > + ret = __iio_str_to_fixpoint(buf, fract_mult, &integer, &fract, > + scale_db); > if (ret) > return ret; > } > - ret = __iio_str_to_fixpoint(buf, fract_mult, &integer, &fract, > - scale_db); > - if (ret) > - return ret; > > ret = indio_dev->info->write_raw(indio_dev, this_attr->c, > integer, fract, this_attr->address);