From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D55CC2BA19 for ; Mon, 6 Apr 2020 09:39:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D3EC62051A for ; Mon, 6 Apr 2020 09:39:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lUin6sw0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726860AbgDFJjw (ORCPT ); Mon, 6 Apr 2020 05:39:52 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:38560 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726675AbgDFJjw (ORCPT ); Mon, 6 Apr 2020 05:39:52 -0400 Received: by mail-pg1-f195.google.com with SMTP id m17so1266254pgj.5 for ; Mon, 06 Apr 2020 02:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=UphhKKOKLoodwVftKKdXY3z6VPYBVP/K0NIVc4HqEz0=; b=lUin6sw0XNT0KJ8AK2i8H7TlaDQXkoCsJVR85w7MC2UsYwyQ69rTBN/0H5cFJq3tsY EI3njv470YcI66Z+laB3Hzun01P/u51mCCOzA5MdYpCSqrrFU/sp33el04XikkYxtYmp wnQldO6+6yd0jvMk44MDR/VF1Ta+TCgjmu91F+FjjWhJs8vY2Jr7sXEDvGrLOA974lLo nwOpHqxoJh4kqnPZH80LPFSebZIxoWwLO5uAeFUilT5t+3s0anVt2mliNeDT7mNfEQ0u AgCCmqrrMCVs04l8m23JwIfyhbVfC0Lhzxyomkg6qeK7tURpN0Abie+EwlVXLeJuenEV fNEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=UphhKKOKLoodwVftKKdXY3z6VPYBVP/K0NIVc4HqEz0=; b=D0UqKdNbHefPPK1opCf5BKK1EcZzyNTlxYTH6QgU7Hctm5+OEJFuUF6iwVwRnSEBWZ X4fs1Fznw2zFEpbHTc9yKcCZgyAMbUneb/o03F6E8m3OlWvE5L4hr03C+vvtaaFZ/mcm PNmKSaWk1Mei0gIRzhBDwhM0FtFxpQz9iS2G+TY4yF+0ajRYYq7ysaildOaDkbqWyTGd 9q/+i22O1HQOqJExuLhyjosgkHeN6SYHnbLJn9lrIERuw6d/bLNIp8qZWB6/xPGugPoL P9w1CF4MQgsvNwMDkHkC2DfhK2xQPbz9sFSgMxdZf8W+kkDhrHYeImDijZ0RRwBf1xeP oNvA== X-Gm-Message-State: AGi0PuZTU4DR0twjBxfCbNTyzO2fGHgq0jCBhDQcA9y22ESH3RtNXOfs 3EzQT0TsUMoEtIW9bn8glZEy7ihv X-Google-Smtp-Source: APiQypLJ5Y3misFwUfgYpGklC18wiNMPhOZ1LWHezVl5ddP3cePBI+Oo7rsxkPHJGRmbCdra+q0o+Q== X-Received: by 2002:a63:2057:: with SMTP id r23mr20805535pgm.232.1586165990812; Mon, 06 Apr 2020 02:39:50 -0700 (PDT) Received: from localhost (n112120135125.netvigator.com. [112.120.135.125]) by smtp.gmail.com with ESMTPSA id e7sm11248239pfm.3.2020.04.06.02.39.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Apr 2020 02:39:50 -0700 (PDT) From: Qiujun Huang To: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, oohall@gmail.com Cc: tglx@linutronix.de, Markus.Elfring@web.de, christophe.leroy@c-s.fr, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Qiujun Huang Subject: [PATCH v4] powerpc/powernv: add NULL check after kzalloc in opal_add_one_export Date: Mon, 6 Apr 2020 17:39:44 +0800 Message-Id: <20200406093944.4174-1-hqjagain@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Here needs a NULL check as kzalloc may fail returning NULL. Issue was found by coccinelle. Generated by: scripts/coccinelle/null/kmerr.cocci Signed-off-by: Qiujun Huang Reviewed-by: Oliver O'Halloran --- v3->v4: Added the information about coccinelle script. Added change log. Added Oliver's Reviewed-by. v2->v3: Removed redundant assignment to 'attr' and 'name'. v1->v2: Just return -ENOMEM if attr is NULL. --- arch/powerpc/platforms/powernv/opal.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c index 2b3dfd0b6cdd..908d749bcef5 100644 --- a/arch/powerpc/platforms/powernv/opal.c +++ b/arch/powerpc/platforms/powernv/opal.c @@ -801,16 +801,19 @@ static ssize_t export_attr_read(struct file *fp, struct kobject *kobj, static int opal_add_one_export(struct kobject *parent, const char *export_name, struct device_node *np, const char *prop_name) { - struct bin_attribute *attr = NULL; - const char *name = NULL; + struct bin_attribute *attr; + const char *name; u64 vals[2]; int rc; rc = of_property_read_u64_array(np, prop_name, &vals[0], 2); if (rc) - goto out; + return rc; attr = kzalloc(sizeof(*attr), GFP_KERNEL); + if (!attr) + return -ENOMEM; + name = kstrdup(export_name, GFP_KERNEL); if (!name) { rc = -ENOMEM; -- 2.17.1