From: Dan Carpenter <dan.carpenter@oracle.com>
To: Michael Straube <straube.linux@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net
Subject: Re: [PATCH 1/2] staging: rtl8188eu: remove unnecessary asignment
Date: Mon, 6 Apr 2020 14:25:20 +0300 [thread overview]
Message-ID: <20200406112519.GH2001@kadam> (raw)
In-Reply-To: <20200405112230.31975-1-straube.linux@gmail.com>
On Sun, Apr 05, 2020 at 01:22:29PM +0200, Michael Straube wrote:
> Remove unnecessary asignment in SwLedBlink1(). The code path with the
> asignment 'pLed->BlinkTimes = 0' is only executed when
> 'pLed->BlinkTimes' is already zero and the value is not changed between
> the test 'if (pLed->BlinkTimes == 0)' and the asignment.
>
Better to get rid of the bStopBlinking variable and this becomes more
obvious.
regards,
dan carpenter
next prev parent reply other threads:[~2020-04-06 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-05 11:22 [PATCH 1/2] staging: rtl8188eu: remove unnecessary asignment Michael Straube
2020-04-05 11:22 ` [PATCH 2/2] staging: rtl8188eu: remove unnecessary variable Michael Straube
2020-04-06 11:25 ` Dan Carpenter [this message]
2020-04-06 11:26 ` [PATCH 1/2] staging: rtl8188eu: remove unnecessary asignment Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406112519.GH2001@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox