Re: [PATCH 23/70] x86/sev-es: Add support for handling IOIO exceptions

Joerg Roedel
2020-03-20T22:24:34Z

On Fri, Mar 20, 2020 at 02:03:17PM -0700, David Rientjes wrote:
> On Thu, 19 Mar 2020, Joerg Roedel wrote:
> > + if (exit_info_1 & IOIO_TYPE_STR) {
> > + int df = (regs->flags & X86_EFLAGS_DF) ? -1 : 1;
> > [ ... ]
> > + if (!(exit_info_1 & IOIO_TYPE_IN)) {
> > + ret = vc_insn_string_read(ctxt,
> > + (void *)(es_base + regs->si),
> > + ghcb->shared_buffer, io_bytes,
> > + exit_info_2, df);
>
> The last argument to vc_insn_string_read() is "bool backwards" which in
> this case it appears will always be true?

Right, thanks, good catch, I'll fix this. Seems to be a leftover from a
previous version.

Regards,

Joerg