From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F430C2BA19 for ; Mon, 6 Apr 2020 12:53:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00E1322204 for ; Mon, 6 Apr 2020 12:53:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rrrAbP73" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728183AbgDFMxC (ORCPT ); Mon, 6 Apr 2020 08:53:02 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:43488 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728077AbgDFMxB (ORCPT ); Mon, 6 Apr 2020 08:53:01 -0400 Received: by mail-pg1-f195.google.com with SMTP id s4so376101pgk.10 for ; Mon, 06 Apr 2020 05:52:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=K7FMm9TMPU2qrk84mTQv2iPYDxxJSQ/dj4GfvVj1fPY=; b=rrrAbP73yD1ONDLTJHHC1edjnAz/00GjC3TLiTQauyplI1K0G6mcDZER5itCStgNul yEIizr773ToeQHFL7xgIGaMoJaElXJy+Fvo10z0KlxP5xwDR+AiVFVaAQQ8wt6vrZJuO E0MVHVBcVNw8JHGotScE7QKBMMHaIrEIrvp3s+pvNp36yxuwIf4yfhcZq9Kesu61IcD/ DE3V/TdKBQ0Nd0z2bSIOLQdjSc6d7iHJdM1MEqA11Wy/wkhNevInHzNMcwJzo22kAlyl 7eFZBJj3FPfdwewQVg/Kod4pAE/fqy9m7fJkmRgtI+FOmj1kf7++ZEl//uT4FwzeBuwb if6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=K7FMm9TMPU2qrk84mTQv2iPYDxxJSQ/dj4GfvVj1fPY=; b=ZbBv9l0FHW9sC0AMd98g+YwE4K2OcVWGzxRFCLLgqtX5BL5sLFAsZ8f5uOP9MhFi8u d/knhwdQ8UORZuxRG3glivwNRFYlu08r8+ozpSlLb34iBKNek9i5ADRr/Ml2w+mjuWf/ PN4WjE2KhrrM5WPtNmU8kyhq8cYo6rV6nLFSzGYD1n0qSSgVlw03nMYG+DmIuYps9t+2 FgcyDTVUkTCeQuQ9wK8INvxC8oHAzSd6VhSnkpRELb8vDrD7iBIzTpp+aklbVxAubLWu XQcLIZTFZivAwNtWPJIyOMbCEAUVe9D+kFycKDUWybk0xKgwopM+2tjVi2qcxyagW1+b pnKQ== X-Gm-Message-State: AGi0PuYObNdZCRlh50RMzP4DxBVLIr/VFzQWZq0BjvUEhIzqaDCie9Ez 8/3ZLNiKdQMEzpyTv4AUZtQ= X-Google-Smtp-Source: APiQypJluYV8v1xRV51ls0+EjZR690Elsj1PdDoZoSspzpE1nvsNRa/80w2Kxh3Myp/I6Lbi7JZvDA== X-Received: by 2002:a62:1cf:: with SMTP id 198mr21700306pfb.246.1586177578658; Mon, 06 Apr 2020 05:52:58 -0700 (PDT) Received: from localhost (n112120135125.netvigator.com. [112.120.135.125]) by smtp.gmail.com with ESMTPSA id u129sm11493248pfb.101.2020.04.06.05.52.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Apr 2020 05:52:58 -0700 (PDT) From: Qiujun Huang To: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, oohall@gmail.com Cc: tglx@linutronix.de, Markus.Elfring@web.de, christophe.leroy@c-s.fr, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Qiujun Huang Subject: [PATCH v5 2/2] powerpc/powernv: Add NULL check after kzalloc in opal_add_one_export Date: Mon, 6 Apr 2020 20:52:42 +0800 Message-Id: <20200406125242.4973-3-hqjagain@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200406125242.4973-1-hqjagain@gmail.com> References: <20200406125242.4973-1-hqjagain@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Here needs a NULL check, as kzalloc may fail returning NULL. Issue was found by coccinelle. Generated by: scripts/coccinelle/null/kmerr.cocci Signed-off-by: Qiujun Huang Reviewed-by: Oliver O'Halloran --- arch/powerpc/platforms/powernv/opal.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c index 71af1cbc6334..908d749bcef5 100644 --- a/arch/powerpc/platforms/powernv/opal.c +++ b/arch/powerpc/platforms/powernv/opal.c @@ -811,6 +811,9 @@ static int opal_add_one_export(struct kobject *parent, const char *export_name, return rc; attr = kzalloc(sizeof(*attr), GFP_KERNEL); + if (!attr) + return -ENOMEM; + name = kstrdup(export_name, GFP_KERNEL); if (!name) { rc = -ENOMEM; -- 2.17.1