public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jin Yao <yao.jin@linux.intel.com>,
	jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
	alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
	ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf stat: Fix no metric header if --per-socket and --metric-only set
Date: Mon, 6 Apr 2020 11:12:06 -0300	[thread overview]
Message-ID: <20200406141206.GF29826@kernel.org> (raw)
In-Reply-To: <20200403094500.GH2784502@krava>

Em Fri, Apr 03, 2020 at 11:45:00AM +0200, Jiri Olsa escreveu:
> On Wed, Apr 01, 2020 at 02:02:26AM +0800, Jin Yao wrote:
> > We received a report that was no metric header displayed if --per-socket
> > and --metric-only were both set.
> > 
> > It's hard for script to parse the perf-stat output. This patch fixes this
> > issue.
> > 
> > Before:
> > 
> >   root@kbl-ppc:~# perf stat -a -M CPI --metric-only --per-socket
> >   ^C
> >    Performance counter stats for 'system wide':
> > 
> >   S0        8                  2.6
> > 
> >          2.215270071 seconds time elapsed
> > 
> >   root@kbl-ppc:~# perf stat -a -M CPI --metric-only --per-socket -I1000
> >   #           time socket cpus
> >        1.000411692 S0        8                  2.2
> >        2.001547952 S0        8                  3.4
> >        3.002446511 S0        8                  3.4
> >        4.003346157 S0        8                  4.0
> >        5.004245736 S0        8                  0.3
> > 
> > After:
> > 
> >   root@kbl-ppc:~# perf stat -a -M CPI --metric-only --per-socket
> >   ^C
> >    Performance counter stats for 'system wide':
> > 
> >                                CPI
> >   S0        8                  2.1
> > 
> >          1.813579830 seconds time elapsed
> > 
> >   root@kbl-ppc:~# perf stat -a -M CPI --metric-only --per-socket -I1000
> >   #           time socket cpus                  CPI
> >        1.000415122 S0        8                  3.2
> >        2.001630051 S0        8                  2.9
> >        3.002612278 S0        8                  4.3
> >        4.003523594 S0        8                  3.0
> >        5.004504256 S0        8                  3.7
> > 
> > Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
> 
> Acked-by: Jiri Olsa <jolsa@redhat.com>

Thanks, applied.

- Arnaldo

  reply	other threads:[~2020-04-06 14:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-31 18:02 [PATCH] perf stat: Fix no metric header if --per-socket and --metric-only set Jin Yao
2020-04-03  9:45 ` Jiri Olsa
2020-04-06 14:12   ` Arnaldo Carvalho de Melo [this message]
2020-04-16  8:31 ` [tip: perf/urgent] " tip-bot2 for Jin Yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200406141206.GF29826@kernel.org \
    --to=arnaldo.melo@gmail.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox