From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, Sudeep Dutt <sudeep.dutt@intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Vadim Pasternak <vadimp@mellanox.com>,
Jason Wang <jasowang@redhat.com>,
platform-driver-x86@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2 1/2] virtio: stop using legacy struct vring
Date: Mon, 6 Apr 2020 17:56:02 +0200 [thread overview]
Message-ID: <20200406155602.GA160445@kroah.com> (raw)
In-Reply-To: <20200406153245.127680-2-mst@redhat.com>
On Mon, Apr 06, 2020 at 11:35:23AM -0400, Michael S. Tsirkin wrote:
> struct vring (in the uapi directory) and supporting APIs are kept
> around to avoid breaking old userspace builds.
> It's not actually part of the UAPI - it was kept in the UAPI
> header by mistake, and using it in kernel isn't necessary
> and prevents us from making changes safely.
> In particular, the APIs actually assume the legacy layout.
>
> Add struct vring_s (identical ATM) and supporting
> legacy APIs and switch everyone to use that.
How are we going to know that "struct vring_s" is what we need/want to
use? What does "_s" mean?
"struct vring_kernel"?
naming is hard...
greg k-h
next prev parent reply other threads:[~2020-04-06 15:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 15:35 [PATCH v2 0/2] virtio: alignment issues Michael S. Tsirkin
2020-04-06 15:35 ` [PATCH v2 1/2] virtio: stop using legacy struct vring Michael S. Tsirkin
2020-04-06 15:56 ` Greg Kroah-Hartman [this message]
2020-04-06 15:57 ` Michael S. Tsirkin
2020-04-06 15:35 ` [PATCH v2 2/2] vhost: force spec specified alignment on types Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406155602.GA160445@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=ashutosh.dixit@intel.com \
--cc=dvhart@infradead.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sudeep.dutt@intel.com \
--cc=vadimp@mellanox.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox