From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D3FBC2BA17 for ; Mon, 6 Apr 2020 15:56:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43CA0248E7 for ; Mon, 6 Apr 2020 15:56:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586188568; bh=+3xwSPG5fNQlWz5dLxBAg7wLH73FhUVhMlCTgn4mUrI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=LXh4FI4rHXY8uF7eGFiNuEedT8bZPAjgYVuAtPAAfrElG7W+YDu8akTFeg+LBCcAu 97TnKOs5uq2JaZy9uJP11XnDsu4gEUmIU3/WcCPvObLbIGQH0qZJzPVkB4IakDqGdU Zd1FvK4fkG/XENSF6l75MoJ0GBbb25NXI+POmcRk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729132AbgDFP4H (ORCPT ); Mon, 6 Apr 2020 11:56:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:58600 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728645AbgDFP4H (ORCPT ); Mon, 6 Apr 2020 11:56:07 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 91222248B9; Mon, 6 Apr 2020 15:56:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586188566; bh=+3xwSPG5fNQlWz5dLxBAg7wLH73FhUVhMlCTgn4mUrI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JxriaKdrqBa1M0yXrn7jw5T5uqtxLs9RbO4XF1mRU54zloISxhNeB26IYgNvOvS6n 007qWUYQHXpoUVgbHkqP9pd6tyW3+YimSXx3MRt0nbgacGMg/eyrCBwenYgWrvE0Sz bhpnoHMtSUt4Y+TiVbxrTRLz/zStywgHpLJE63L4= Date: Mon, 6 Apr 2020 17:56:02 +0200 From: Greg Kroah-Hartman To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Sudeep Dutt , Ashutosh Dixit , Arnd Bergmann , Andy Shevchenko , Darren Hart , Vadim Pasternak , Jason Wang , platform-driver-x86@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 1/2] virtio: stop using legacy struct vring Message-ID: <20200406155602.GA160445@kroah.com> References: <20200406153245.127680-1-mst@redhat.com> <20200406153245.127680-2-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200406153245.127680-2-mst@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 06, 2020 at 11:35:23AM -0400, Michael S. Tsirkin wrote: > struct vring (in the uapi directory) and supporting APIs are kept > around to avoid breaking old userspace builds. > It's not actually part of the UAPI - it was kept in the UAPI > header by mistake, and using it in kernel isn't necessary > and prevents us from making changes safely. > In particular, the APIs actually assume the legacy layout. > > Add struct vring_s (identical ATM) and supporting > legacy APIs and switch everyone to use that. How are we going to know that "struct vring_s" is what we need/want to use? What does "_s" mean? "struct vring_kernel"? naming is hard... greg k-h