From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC694C2BA1A for ; Tue, 7 Apr 2020 00:04:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D13A2078A for ; Tue, 7 Apr 2020 00:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586217845; bh=t5mZqqZHyeWCsyhnrYk3hzJdnVAk7wdpgPo8EGT3/cU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=eekzZgylYmdtQp+nFAst6x2ho7AFUar8Mz1AS5ETGnXmecEUFl/jKCdt7uQv+f0fM Dg9xoHYBsGPb8MlU5XWgBYY1FiXv/yEh5JIMmEApe/c59xQgVNdD+kMPgCDbetTIoQ 7DyTjS/ewn1Tzu5O5vdaHK4d4QIJa3v+OzJCSbp4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728459AbgDGAEE (ORCPT ); Mon, 6 Apr 2020 20:04:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:38088 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728321AbgDGADA (ORCPT ); Mon, 6 Apr 2020 20:03:00 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B4622082D; Tue, 7 Apr 2020 00:02:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586217780; bh=t5mZqqZHyeWCsyhnrYk3hzJdnVAk7wdpgPo8EGT3/cU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R/j5lsL487V1zRSpEELDQdojFm2t4kSULGihdhFAOni3QoA222azgEAcaQm4uLXUT 3J0tFnYb+JxfcUnGj6ZkarFnwfPoJ5n3wCxRAzfZBuwa8CDokf8JJCJIHg+Ps0/dgh 36EKzVcMDosVe17IgTIskyMLv0awIl5ksmfLGJnM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Pablo Neira Ayuso , Phil Sutter , Stefano Brivio , Sasha Levin , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 6/9] netfilter: nf_tables: Allow set back-ends to report partial overlaps on insertion Date: Mon, 6 Apr 2020 20:02:49 -0400 Message-Id: <20200407000252.17241-6-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200407000252.17241-1-sashal@kernel.org> References: <20200407000252.17241-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pablo Neira Ayuso [ Upstream commit 8c2d45b2b65ca1f215244be1c600236e83f9815f ] Currently, the -EEXIST return code of ->insert() callbacks is ambiguous: it might indicate that a given element (including intervals) already exists as such, or that the new element would clash with existing ones. If identical elements already exist, the front-end is ignoring this without returning error, in case NLM_F_EXCL is not set. However, if the new element can't be inserted due an overlap, we should report this to the user. To this purpose, allow set back-ends to return -ENOTEMPTY on collision with existing elements, translate that to -EEXIST, and return that to userspace, no matter if NLM_F_EXCL was set. Reported-by: Phil Sutter Signed-off-by: Stefano Brivio Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- net/netfilter/nf_tables_api.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 91490446ebb42..cda18a94385be 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -4058,6 +4058,11 @@ static int nft_add_set_elem(struct nft_ctx *ctx, struct nft_set *set, err = -EBUSY; else if (!(nlmsg_flags & NLM_F_EXCL)) err = 0; + } else if (err == -ENOTEMPTY) { + /* ENOTEMPTY reports overlapping between this element + * and an existing one. + */ + err = -EEXIST; } goto err5; } -- 2.20.1