From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ohad Ben-Cohen <ohad@wizery.com>,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v8 15/19] remoteproc: switch to virtio_legacy_init/size
Date: Mon, 6 Apr 2020 22:30:41 -0700 [thread overview]
Message-ID: <20200407053041.GH20625@builder.lan> (raw)
In-Reply-To: <20200407011612.478226-16-mst@redhat.com>
On Mon 06 Apr 18:16 PDT 2020, Michael S. Tsirkin wrote:
> These are used for legacy ring format, switch to APIs that make this
> explicit.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/remoteproc/remoteproc_core.c | 2 +-
> drivers/remoteproc/remoteproc_virtio.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index 097f33e4f1f3..c350a01e6c4e 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -322,7 +322,7 @@ int rproc_alloc_vring(struct rproc_vdev *rvdev, int i)
> struct rproc_mem_entry *mem;
>
> /* actual size of vring (in bytes) */
> - size = PAGE_ALIGN(vring_size(rvring->len, rvring->align));
> + size = PAGE_ALIGN(vring_legacy_size(rvring->len, rvring->align));
>
> rsc = (void *)rproc->table_ptr + rvdev->rsc_offset;
>
> diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c
> index 8c07cb2ca8ba..35b02468197a 100644
> --- a/drivers/remoteproc/remoteproc_virtio.c
> +++ b/drivers/remoteproc/remoteproc_virtio.c
> @@ -95,7 +95,7 @@ static struct virtqueue *rp_find_vq(struct virtio_device *vdev,
> len = rvring->len;
>
> /* zero vring */
> - size = vring_size(len, rvring->align);
> + size = vring_legacy_size(len, rvring->align);
> memset(addr, 0, size);
>
> dev_dbg(dev, "vring%d: va %pK qsz %d notifyid %d\n",
> --
> MST
>
next prev parent reply other threads:[~2020-04-07 5:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 1:16 [PATCH v8 00/19] virtio: alignment issues Michael S. Tsirkin
2020-04-07 1:16 ` [PATCH v8 01/19] tools/virtio: define aligned attribute Michael S. Tsirkin
2020-04-07 1:16 ` [PATCH v8 02/19] tools/virtio: make asm/barrier.h self contained Michael S. Tsirkin
2020-04-07 1:16 ` [PATCH v8 03/19] tools/virtio: define __KERNEL__ Michael S. Tsirkin
2020-04-07 1:16 ` [PATCH v8 04/19] virtio: add VIRTIO_RING_NO_LEGACY Michael S. Tsirkin
2020-04-07 1:16 ` [PATCH v8 05/19] virtgpu: pull in uaccess.h Michael S. Tsirkin
2020-04-07 1:16 ` [PATCH v8 06/19] virtio-rng: pull in slab.h Michael S. Tsirkin
2020-04-07 1:16 ` [PATCH v8 07/19] remoteproc: " Michael S. Tsirkin
2020-04-07 5:31 ` Bjorn Andersson
2020-04-07 1:16 ` [PATCH v8 08/19] virtio_input: " Michael S. Tsirkin
2020-04-07 1:16 ` [PATCH v8 09/19] virtio: stop using legacy struct vring in kernel Michael S. Tsirkin
2020-04-07 8:51 ` Stefan Hajnoczi
2020-04-07 1:16 ` [PATCH v8 10/19] vhost: force spec specified alignment on types Michael S. Tsirkin
2020-04-07 1:16 ` [PATCH v8 11/19] virtio: add legacy init/size APIs Michael S. Tsirkin
2020-04-07 1:16 ` [PATCH v8 12/19] virtio_ring: switch to virtio_legacy_init/size Michael S. Tsirkin
2020-04-07 1:16 ` [PATCH v8 13/19] tools/virtio: " Michael S. Tsirkin
2020-04-07 1:16 ` [PATCH v8 14/19] vop: " Michael S. Tsirkin
2020-04-07 1:16 ` [PATCH v8 15/19] remoteproc: " Michael S. Tsirkin
2020-04-07 5:30 ` Bjorn Andersson [this message]
2020-04-07 1:17 ` [PATCH v8 16/19] mellanox: " Michael S. Tsirkin
2020-04-07 1:17 ` [PATCH v8 17/19] vhost: option to fetch descriptors through an independent struct Michael S. Tsirkin
2020-04-07 1:17 ` [PATCH v8 18/19] vhost: use batched version by default Michael S. Tsirkin
2020-04-07 1:17 ` [PATCH v8 19/19] vhost: batching fetches Michael S. Tsirkin
2020-04-07 3:44 ` [PATCH v8 00/19] virtio: alignment issues Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407053041.GH20625@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mst@redhat.com \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox