* [PATCH] soc: qcom: smp2p: Delete an error message in qcom_smp2p_probe()
@ 2020-04-05 16:12 Markus Elfring
2020-04-07 6:15 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-04-05 16:12 UTC (permalink / raw)
To: linux-arm-msm, Andy Gross, Bjorn Andersson
Cc: LKML, kernel-janitors, Tang Bin
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 5 Apr 2020 18:08:13 +0200
The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/soc/qcom/smp2p.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c
index c7300d54e444..07183d731d74 100644
--- a/drivers/soc/qcom/smp2p.c
+++ b/drivers/soc/qcom/smp2p.c
@@ -474,10 +474,8 @@ static int qcom_smp2p_probe(struct platform_device *pdev)
goto report_read_failure;
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "unable to acquire smp2p interrupt\n");
+ if (irq < 0)
return irq;
- }
smp2p->mbox_client.dev = &pdev->dev;
smp2p->mbox_client.knows_txdone = true;
--
2.26.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] soc: qcom: smp2p: Delete an error message in qcom_smp2p_probe()
2020-04-05 16:12 [PATCH] soc: qcom: smp2p: Delete an error message in qcom_smp2p_probe() Markus Elfring
@ 2020-04-07 6:15 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2020-04-07 6:15 UTC (permalink / raw)
To: Markus Elfring; +Cc: linux-arm-msm, Andy Gross, LKML, kernel-janitors, Tang Bin
On Sun 05 Apr 09:12 PDT 2020, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 5 Apr 2020 18:08:13 +0200
>
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Thanks Markus, picked up for 5.8.
Regards,
Bjorn
> ---
> drivers/soc/qcom/smp2p.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c
> index c7300d54e444..07183d731d74 100644
> --- a/drivers/soc/qcom/smp2p.c
> +++ b/drivers/soc/qcom/smp2p.c
> @@ -474,10 +474,8 @@ static int qcom_smp2p_probe(struct platform_device *pdev)
> goto report_read_failure;
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(&pdev->dev, "unable to acquire smp2p interrupt\n");
> + if (irq < 0)
> return irq;
> - }
>
> smp2p->mbox_client.dev = &pdev->dev;
> smp2p->mbox_client.knows_txdone = true;
> --
> 2.26.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-07 6:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-05 16:12 [PATCH] soc: qcom: smp2p: Delete an error message in qcom_smp2p_probe() Markus Elfring
2020-04-07 6:15 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox