From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Petr Mladek <pmladek@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Randy Dunlap <rdunlap@infradead.org>,
Kees Cook <keescook@chromium.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
"Tobin C . Harding" <me@tobin.cc>
Subject: Re: [PATCH v2] vsprintf: don't obfuscate NULL and error pointers
Date: Wed, 8 Apr 2020 18:06:43 +0300 [thread overview]
Message-ID: <20200408150643.GD3676135@smile.fi.intel.com> (raw)
In-Reply-To: <CAOi1vP-K-AwzPqdHHDFDvef_nLPx3pr2NnQnSo5Emvsc1hF7Cg@mail.gmail.com>
On Wed, Apr 08, 2020 at 04:38:25PM +0200, Ilya Dryomov wrote:
> On Wed, Apr 8, 2020 at 12:31 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > On Wed, Apr 8, 2020 at 12:45 AM Ilya Dryomov <idryomov@gmail.com> wrote:
> > > On Wed, Feb 19, 2020 at 8:23 PM Ilya Dryomov <idryomov@gmail.com> wrote:
> >
> > > Hi Petr,
> > >
> > > Bump, as I don't see this in linux-next or other public branches.
> > > The discussion was split between several threads, revolving around
> > > the vision for how lib/test_printf.c should be structured, but the
> > > fix itself wasn't disputed.
> > >
> > > Could you please pick it up for 5.7-rc1? If you want to restructure
> > > the test suite before adding any new test cases, v1 doesn't have them.
> > > Other than the test cases, the only difference between v1 and v2 is
> > > added reviews and acks.
> >
> > Petr has some obstacles that prevent him to pay attention on this and
> > actually do anything right now for Linux kernel.
> > If Rasmus, Sergey, you and maybe others will got consensus here, I
> > think Andrew can take it thru his tree.
>
> Thanks for letting us know, Andy.
>
> Other than Petr, two people are listed as maintainers of vsprintf.c:
> Sergey and Steve. Both of them were fine with v1 (no tests) and sent
> their acks.
>
> Rasmus, you wanted to see some tests, so I posted v2. However Petr
> wanted to restructure the test suite first, and it didn't seem like you
> him agreed on what exactly that should look like. Which would you
> prefer to be picked by Andrew, v1 or v2?
I think it's question to maintainers. I'm a reviewer here.
For the better understanding the current state of affairs I suggest to respin
new version after rc1 and we will see again.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-04-08 15:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 17:12 [PATCH v2] vsprintf: don't obfuscate NULL and error pointers Ilya Dryomov
2020-02-19 17:37 ` Andy Shevchenko
2020-02-19 18:07 ` Ilya Dryomov
2020-02-19 19:23 ` Ilya Dryomov
2020-04-07 21:45 ` Ilya Dryomov
2020-04-07 22:31 ` Andy Shevchenko
2020-04-08 14:38 ` Ilya Dryomov
2020-04-08 15:06 ` Andy Shevchenko [this message]
2020-04-08 15:52 ` Ilya Dryomov
2020-04-08 16:23 ` Linus Torvalds
2020-04-10 9:40 ` David Laight
2020-04-13 9:24 ` Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200408150643.GD3676135@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=idryomov@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=me@tobin.cc \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox