* Re: [PATCH] drm/panel: boe-tv101wum-n16: extend LCD support list
[not found] <20200324075734.1802-1-david.lu@bitland.com.cn>
@ 2020-03-31 7:01 ` Nicolas Boichat
2020-04-08 20:22 ` Sam Ravnborg
1 sibling, 0 replies; 2+ messages in thread
From: Nicolas Boichat @ 2020-03-31 7:01 UTC (permalink / raw)
To: David Lu
Cc: David Airlie, lkml, dri-devel, jungle.chiang, Thierry Reding,
Sam Ravnborg
On Wed, Mar 25, 2020 at 4:17 PM David Lu <david.lu@bitland.com.cn> wrote:
>
No very strong opinion, but for consistency, I'd have this as a title:
drm/panel: support for boe,tv105wum-nw0 dsi video mode panel
> Add entries for BOE TV105WUM-NW0 10.5" WUXGA TFT LCD panel.
>
> Signed-off-by: David Lu <david.lu@bitland.com.cn>
> Change-Id: I5b1cef259de5fb498220dcc47baa035083c41667
No Change-Id please.
Otherwise:
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
> ---
> .../gpu/drm/panel/panel-boe-tv101wum-nl6.c | 31 +++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> index 48a164257d18..f89861c8598a 100644
> --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> @@ -696,6 +696,34 @@ static const struct panel_desc auo_b101uan08_3_desc = {
> .init_cmds = auo_b101uan08_3_init_cmd,
> };
>
> +static const struct drm_display_mode boe_tv105wum_nw0_default_mode = {
> + .clock = 159260,
> + .hdisplay = 1200,
> + .hsync_start = 1200 + 80,
> + .hsync_end = 1200 + 80 + 24,
> + .htotal = 1200 + 80 + 24 + 60,
> + .vdisplay = 1920,
> + .vsync_start = 1920 + 10,
> + .vsync_end = 1920 + 10 + 2,
> + .vtotal = 1920 + 10 + 2 + 14,
> + .vrefresh = 60,
> + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
> +};
> +
> +static const struct panel_desc boe_tv105wum_nw0_desc = {
> + .modes = &boe_tv105wum_nw0_default_mode,
> + .bpc = 8,
> + .size = {
> + .width_mm = 141,
> + .height_mm = 226,
> + },
> + .lanes = 4,
> + .format = MIPI_DSI_FMT_RGB888,
> + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> + MIPI_DSI_MODE_LPM,
> + .init_cmds = boe_init_cmd,
> +};
> +
> static int boe_panel_get_modes(struct drm_panel *panel,
> struct drm_connector *connector)
> {
> @@ -834,6 +862,9 @@ static const struct of_device_id boe_of_match[] = {
> { .compatible = "auo,b101uan08.3",
> .data = &auo_b101uan08_3_desc
> },
> + { .compatible = "boe,tv105wum-nw0",
> + .data = &boe_tv105wum_nw0_desc
> + },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, boe_of_match);
> --
> 2.24.1
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/panel: boe-tv101wum-n16: extend LCD support list
[not found] <20200324075734.1802-1-david.lu@bitland.com.cn>
2020-03-31 7:01 ` [PATCH] drm/panel: boe-tv101wum-n16: extend LCD support list Nicolas Boichat
@ 2020-04-08 20:22 ` Sam Ravnborg
1 sibling, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2020-04-08 20:22 UTC (permalink / raw)
To: David Lu
Cc: David Airlie, linux-kernel, dri-devel, jungle.chiang,
Thierry Reding
Hi David.
On Tue, Mar 24, 2020 at 03:57:34PM +0800, David Lu wrote:
> Add entries for BOE TV105WUM-NW0 10.5" WUXGA TFT LCD panel.
>
> Signed-off-by: David Lu <david.lu@bitland.com.cn>
> Change-Id: I5b1cef259de5fb498220dcc47baa035083c41667
Deleted Change-Id, and updated subject as suggested by Nicholas.
Applied to drm-misc-next and pushed out.
Sam
> ---
> .../gpu/drm/panel/panel-boe-tv101wum-nl6.c | 31 +++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> index 48a164257d18..f89861c8598a 100644
> --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> @@ -696,6 +696,34 @@ static const struct panel_desc auo_b101uan08_3_desc = {
> .init_cmds = auo_b101uan08_3_init_cmd,
> };
>
> +static const struct drm_display_mode boe_tv105wum_nw0_default_mode = {
> + .clock = 159260,
> + .hdisplay = 1200,
> + .hsync_start = 1200 + 80,
> + .hsync_end = 1200 + 80 + 24,
> + .htotal = 1200 + 80 + 24 + 60,
> + .vdisplay = 1920,
> + .vsync_start = 1920 + 10,
> + .vsync_end = 1920 + 10 + 2,
> + .vtotal = 1920 + 10 + 2 + 14,
> + .vrefresh = 60,
> + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
> +};
> +
> +static const struct panel_desc boe_tv105wum_nw0_desc = {
> + .modes = &boe_tv105wum_nw0_default_mode,
> + .bpc = 8,
> + .size = {
> + .width_mm = 141,
> + .height_mm = 226,
> + },
> + .lanes = 4,
> + .format = MIPI_DSI_FMT_RGB888,
> + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> + MIPI_DSI_MODE_LPM,
> + .init_cmds = boe_init_cmd,
> +};
> +
> static int boe_panel_get_modes(struct drm_panel *panel,
> struct drm_connector *connector)
> {
> @@ -834,6 +862,9 @@ static const struct of_device_id boe_of_match[] = {
> { .compatible = "auo,b101uan08.3",
> .data = &auo_b101uan08_3_desc
> },
> + { .compatible = "boe,tv105wum-nw0",
> + .data = &boe_tv105wum_nw0_desc
> + },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, boe_of_match);
> --
> 2.24.1
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread