From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Corentin Labbe <clabbe@baylibre.com>,
Nagarjuna Kristam <nkristam@nvidia.com>,
Thierry Reding <treding@nvidia.com>,
Vidya Sagar <vidyas@nvidia.com>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] phy: tegra: fix USB dependencies
Date: Thu, 9 Apr 2020 15:24:35 +0200 [thread overview]
Message-ID: <20200409132435.GA3263479@ulmo> (raw)
In-Reply-To: <20200408200828.124139-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 1725 bytes --]
On Wed, Apr 08, 2020 at 10:08:14PM +0200, Arnd Bergmann wrote:
> Without CONFIG_USB_SUPPORT, we can get a couple of warnings for
> missing dependencies:
>
> WARNING: unmet direct dependencies detected for USB_PHY
> Depends on [n]: USB_SUPPORT [=n]
> Selected by [m]:
> - PHY_TEGRA_XUSB [=m] && ARCH_TEGRA [=y]
>
> WARNING: unmet direct dependencies detected for USB_CONN_GPIO
> Depends on [n]: USB_SUPPORT [=n] && GPIOLIB [=y]
> Selected by [m]:
> - PHY_TEGRA_XUSB [=m] && ARCH_TEGRA [=y]
>
> Fixes: 6835bdc99580 ("phy: tegra: Select USB_PHY")
> Fixes: f67213cee2b3 ("phy: tegra: xusb: Add usb-role-switch support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/phy/tegra/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I sent a similar patch a couple of days ago:
http://patchwork.ozlabs.org/patch/1263865/
This should be applied by Greg on top of the PR that I sent for USB. I
did get the semi-automated "we're in the merge window" reply from Greg,
but I was under the impression that he still applied fixes during the
merge window. It seems like he didn't pick this up yet, though.
Greg, anything I should've done differently for you to notice this?
Thierry
> diff --git a/drivers/phy/tegra/Kconfig b/drivers/phy/tegra/Kconfig
> index a208aca4ba7b..4f8c61863411 100644
> --- a/drivers/phy/tegra/Kconfig
> +++ b/drivers/phy/tegra/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config PHY_TEGRA_XUSB
> tristate "NVIDIA Tegra XUSB pad controller driver"
> - depends on ARCH_TEGRA
> + depends on ARCH_TEGRA && USB_SUPPORT
> select USB_CONN_GPIO
> select USB_PHY
> help
> --
> 2.26.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-09 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 20:08 [PATCH] phy: tegra: fix USB dependencies Arnd Bergmann
2020-04-09 13:24 ` Thierry Reding [this message]
2020-04-09 13:47 ` Greg Kroah-Hartman
2020-04-11 9:01 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409132435.GA3263479@ulmo \
--to=thierry.reding@gmail.com \
--cc=arnd@arndb.de \
--cc=clabbe@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nkristam@nvidia.com \
--cc=treding@nvidia.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox