From: Thierry Reding <treding@nvidia.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <soc@kernel.org>, Thierry Reding <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
Dmitry Osipenko <digetx@gmail.com>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Venkat Reddy Talla <vreddytalla@nvidia.com>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] soc: tegra: fix tegra_pmc_get_suspend_mode definition
Date: Thu, 9 Apr 2020 17:02:31 +0200 [thread overview]
Message-ID: <20200409150231.GB3505571@ulmo> (raw)
In-Reply-To: <20200408190127.587768-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
On Wed, Apr 08, 2020 at 09:01:15PM +0200, Arnd Bergmann wrote:
> When CONFIG_PM_SLEEP is disabled, the function is not defined,
> causing a link failure:
>
> arm-linux-gnueabi-ld: drivers/cpuidle/cpuidle-tegra.o: in function `tegra_cpuidle_probe':
> cpuidle-tegra.c:(.text+0x24): undefined reference to `tegra_pmc_get_suspend_mode'
>
> Change the #ifdef check according to the definition.
>
> Fixes: 382ac8e22b90 ("cpuidle: tegra: Disable CC6 state if LP2 unavailable")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> include/soc/tegra/pmc.h | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
Let me know if you'd prefer me to send this in a pull request later on.
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-04-09 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 19:01 [PATCH] soc: tegra: fix tegra_pmc_get_suspend_mode definition Arnd Bergmann
2020-04-08 20:56 ` Dmitry Osipenko
2020-04-09 15:02 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409150231.GB3505571@ulmo \
--to=treding@nvidia.com \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=soc@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vreddytalla@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox