From: Guenter Roeck <linux@roeck-us.net>
To: Philippe Liard <pliard@google.com>
Cc: phillip@squashfs.org.uk, hch@lst.de,
linux-kernel@vger.kernel.org, groeck@chromium.org
Subject: Re: [PATCH v3] squashfs: Migrate from ll_rw_block usage to BIO
Date: Thu, 9 Apr 2020 08:55:21 -0700 [thread overview]
Message-ID: <20200409155521.GA187729@roeck-us.net> (raw)
In-Reply-To: <20191106074238.186023-1-pliard@google.com>
On Wed, Nov 06, 2019 at 04:42:38PM +0900, Philippe Liard wrote:
> The ll_rw_block() function has been deprecated in favor of BIO which
> appears to come with large performance improvements.
>
> This patch decreases boot time by close to 40% when using squashfs for
> the root file-system. This is observed at least in the context of
> starting an Android VM on Chrome OS using crosvm
> (https://chromium.googlesource.com/chromiumos/platform/crosvm). The
> patch was tested on 4.19 as well as master.
>
> This patch is largely based on Adrien Schildknecht's patch that was
> originally sent as https://lkml.org/lkml/2017/9/22/814 though with some
> significant changes and simplifications while also taking Phillip
> Lougher's feedback into account, around preserving support for
> FILE_CACHE in particular.
>
> Signed-off-by: Philippe Liard <pliard@google.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Hmm, I spent a lot of time reviewing this internally, but just realized that
I never sent a
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Sorry for that.
The patch still applies to current mainline. I'll run it through my test
system to give it some basic test coverage.
Guenter
prev parent reply other threads:[~2020-04-09 15:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 7:42 [PATCH v3] squashfs: Migrate from ll_rw_block usage to BIO Philippe Liard
2019-11-06 8:34 ` Christoph Hellwig
2019-11-06 8:37 ` Christoph Hellwig
2019-11-06 9:28 ` Philippe Liard
2019-11-15 1:20 ` Philippe Liard
2020-04-02 15:35 ` Christoph Hellwig
2020-04-03 1:37 ` Philippe Liard
2020-04-08 6:24 ` Christoph Hellwig
2020-04-09 0:38 ` Andrew Morton
2020-04-09 15:55 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409155521.GA187729@roeck-us.net \
--to=linux@roeck-us.net \
--cc=groeck@chromium.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@squashfs.org.uk \
--cc=pliard@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox