Re: [PATCH 07/23] floppy: use symbolic register names in the sparc64 port

Denis Efremov
2020-04-14T09:21:13Z

Hi,

On 3/31/20 12:40 PM, Willy Tarreau wrote:
- printk("floppy: Asked to read unknown port %lx\n", port);
> + printk("floppy: Asked to read unknown port %lx\n", reg);

> - printk("floppy: Asked to write to unknown port %lx\n", port);
> + printk("floppy: Asked to write to unknown port %lx\n", reg);

sparc64 showed a couple of warnings in printks (I will send fixes)
./arch/sparc/include/asm/floppy_64.h: In function ‘sun_82077_fd_inb’:
./arch/sparc/include/asm/floppy_64.h:106:48: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘unsigned int’ [-Wformat=]
106 | printk("floppy: Asked to read unknown port %lx\n", reg);
| ~~^ ~~~
| | |
| | unsigned int
| long unsigned int
| %x
./arch/sparc/include/asm/floppy_64.h: In function ‘sun_82077_fd_outb’:
./arch/sparc/include/asm/floppy_64.h:125:52: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘unsigned int’ [-Wformat=]
125 | printk("floppy: Asked to write to unknown port %lx\n", reg);
| ~~^ ~~~
| | |
| | unsigned int
| long unsigned int
| %x

A couple of new warnings.