From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD0A8C2BB85 for ; Fri, 10 Apr 2020 19:34:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98E422084D for ; Fri, 10 Apr 2020 19:34:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="B23qFvRB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726736AbgDJTe0 (ORCPT ); Fri, 10 Apr 2020 15:34:26 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:22500 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726713AbgDJTe0 (ORCPT ); Fri, 10 Apr 2020 15:34:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586547265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dR0pnT92lTl7PiXH1/vycyqLlKqG/upjftJ1HpISkMA=; b=B23qFvRBondG0uk3w1fbnTLyduYxESk9W7GeV7pwe9WbgI6HE/bFVpdfNa3on7+sN1pK8h LcPdyQaB57XZ/zwtG8bvuKP+TO0DlkbYxav7BHuz1pp2pEmGo/vgkCFS9YbJXSYiLEqrSQ 9powbFokcNRGcMRh9lWnVZJg96aubR8= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-193-Wi6sgRpGNAupTMp_qoUZfw-1; Fri, 10 Apr 2020 15:34:23 -0400 X-MC-Unique: Wi6sgRpGNAupTMp_qoUZfw-1 Received: by mail-qv1-f71.google.com with SMTP id z14so2449978qvk.2 for ; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dR0pnT92lTl7PiXH1/vycyqLlKqG/upjftJ1HpISkMA=; b=Gzi0EbIrulCL2MKMn7tIVKJD5yISfqoY7lHaZhNG9EWRav+aYdhAX+o2QYFAYBnkQx /FVxG+nJS/yhspFuz/10p3AgEYRNSg1Dx84o/Voenu9naWCWNFf/X6SIgqPU6vHvRLm2 +wxssMqWZGOFExK/nmcKliYAl6laLn1XhWtSjCU9OV3G1RhH8WAPqTcElYjG3iV15ahW C13CWIQq95teWAFZ7ol0Xf0eN/ussgD7Cb8tRO7OzDkdLy7cWl610xE8hnqrxfFRyyB2 FbRYHc70QxzxD65qPuB9swpW4ZiMNHOOmouGkOA35BL0aPOIQmPpIwRtU15PkQQmNXhN 2DJg== X-Gm-Message-State: AGi0PuYR81s8REgQsZBlddlxTF9Fhj5hqcrQE7eb8IX6gcr1aiGbP67r VuzbfP78XBhw5DMJS9TJt5WlyR+NvDXCQu1ZJ2o1MH+B7fuC7CDaz6WacjV7YcyO2HFY0ZZn0Q4 idY6p+mzZAysUnA0i9oAWMeBF X-Received: by 2002:ac8:6d06:: with SMTP id o6mr768737qtt.165.1586547263228; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) X-Google-Smtp-Source: APiQypKE+9gdKAAzqM7E075abKl7yEhzpSisddiPAFgdbjLHprLwAVDEdymEnBo0qMB8GT4NFqVJjg== X-Received: by 2002:ac8:6d06:: with SMTP id o6mr768725qtt.165.1586547263017; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id m11sm2214328qkg.130.2020.04.10.12.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2020 12:34:22 -0700 (PDT) Date: Fri, 10 Apr 2020 15:34:19 -0400 From: Peter Xu To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-doc@vger.kernel.org, Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Dave Hansen , Jonathan Corbet , Longpeng , Christophe Leroy , Mina Almasry , Andrew Morton Subject: Re: [PATCH v2 3/4] hugetlbfs: remove hugetlb_add_hstate() warning for existing hstate Message-ID: <20200410193419.GF3172@xz-x1> References: <20200401183819.20647-1-mike.kravetz@oracle.com> <20200401183819.20647-4-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200401183819.20647-4-mike.kravetz@oracle.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 01, 2020 at 11:38:18AM -0700, Mike Kravetz wrote: [...] > @@ -3255,7 +3254,6 @@ void __init hugetlb_add_hstate(unsigned int order) > unsigned long i; > > if (size_to_hstate(PAGE_SIZE << order)) { > - pr_warn("hugepagesz= specified twice, ignoring\n"); > return; > } Nitpick: I think the brackets need to be removed to follow linux coding style. With that: Reviewed-by: Peter Xu -- Peter Xu