public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Douglas Anderson <dianders@chromium.org>
Cc: kbuild-all@lists.01.org, jason.wessel@windriver.com,
	daniel.thompson@linaro.org, gregkh@linuxfoundation.org,
	hpa@zytor.com, kgdb-bugreport@lists.sourceforge.net,
	corbet@lwn.net, frowand.list@gmail.com, tglx@linutronix.de,
	jslaby@suse.com, linux-serial@vger.kernel.org, mingo@redhat.com,
	will@kernel.org, bjorn.andersson@linaro.org, agross@kernel.org,
	bp@alien8.de, catalin.marinas@arm.com,
	Douglas Anderson <dianders@chromium.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] kgdboc: Add earlycon_kgdboc to support early kgdb using boot consoles
Date: Sat, 11 Apr 2020 09:44:40 +0800	[thread overview]
Message-ID: <202004110910.bzdcPg1o%lkp@intel.com> (raw)
In-Reply-To: <20200410151632.4.I8fba5961bf452ab92350654aa61957f23ecf0100@changeid>

[-- Attachment #1: Type: text/plain, Size: 3316 bytes --]

Hi Douglas,

I love your patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on tty/tty-testing v5.6 next-20200410]
[cannot apply to kgdb/kgdb-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Douglas-Anderson/kgdb-Support-late-serial-drivers-enable-early-debug-w-boot-consoles/20200411-062123
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/usb/early/ehci-dbgp.c: In function 'kgdbdbgp_parse_config':
>> drivers/usb/early/ehci-dbgp.c:1060:2: error: too few arguments to function 'kgdb_register_io_module'
     kgdb_register_io_module(&kgdbdbgp_io_ops);
     ^~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/usb/early/ehci-dbgp.c:24:0:
   include/linux/kgdb.h:326:12: note: declared here
    extern int kgdb_register_io_module(struct kgdb_io *new_dbg_io_ops,
               ^~~~~~~~~~~~~~~~~~~~~~~

vim +/kgdb_register_io_module +1060 drivers/usb/early/ehci-dbgp.c

4fe1da4ebc18c4 Jason Wessel 2010-05-20  1046  
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1047  static int __init kgdbdbgp_parse_config(char *str)
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1048  {
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1049  	char *ptr;
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1050  
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1051  	if (!ehci_debug) {
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1052  		if (early_dbgp_init(str))
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1053  			return -1;
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1054  	}
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1055  	ptr = strchr(str, ',');
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1056  	if (ptr) {
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1057  		ptr++;
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1058  		kgdbdbgp_wait_time = simple_strtoul(ptr, &ptr, 10);
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1059  	}
4fe1da4ebc18c4 Jason Wessel 2010-05-20 @1060  	kgdb_register_io_module(&kgdbdbgp_io_ops);
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1061  	kgdbdbgp_io_ops.is_console = early_dbgp_console.index != -1;
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1062  
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1063  	return 0;
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1064  }
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1065  early_param("kgdbdbgp", kgdbdbgp_parse_config);
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1066  

:::::: The code at line 1060 was first introduced by commit
:::::: 4fe1da4ebc18c4c42fa56c228447f68033fce5f0 echi-dbgp: Add kernel debugger support for the usb debug port

:::::: TO: Jason Wessel <jason.wessel@windriver.com>
:::::: CC: Jason Wessel <jason.wessel@windriver.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 71616 bytes --]

  parent reply	other threads:[~2020-04-11  1:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-10 22:17 [PATCH 0/7] kgdb: Support late serial drivers; enable early debug w/ boot consoles Douglas Anderson
2020-04-10 22:17 ` [PATCH 1/7] kgdboc: Use a platform device to handle tty drivers showing up late Douglas Anderson
2020-04-10 22:17 ` [PATCH 2/7] kgdb: Delay "kgdbwait" to dbg_late_init() by default Douglas Anderson
2020-04-10 22:17 ` [PATCH 3/7] arm64: Add call_break_hook() to early_brk64() for early kgdb Douglas Anderson
2020-04-10 22:17 ` [PATCH 4/7] kgdboc: Add earlycon_kgdboc to support early kgdb using boot consoles Douglas Anderson
2020-04-10 23:56   ` kbuild test robot
2020-04-13 21:59     ` Doug Anderson
2020-04-11  1:44   ` kbuild test robot [this message]
2020-04-10 22:17 ` [PATCH 5/7] Documentation: kgdboc: Document new earlycon_kgdboc parameter Douglas Anderson
2020-04-10 22:17 ` [PATCH 6/7] serial: qcom_geni_serial: Support earlycon_kgdboc Douglas Anderson
2020-04-10 22:17 ` [PATCH 7/7] serial: 8250_early: " Douglas Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202004110910.bzdcPg1o%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=daniel.thompson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=jason.wessel@windriver.com \
    --cc=jslaby@suse.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox