Re: [PATCH AUTOSEL 5.6 64/68] btrfs: hold a ref on the root in btrfs_recover_relocation

Sasha Levin
2020-04-13T17:19:46Z

On Fri, Apr 10, 2020 at 12:09:06PM +0200, David Sterba wrote:
>On Thu, Apr 09, 2020 at 11:46:29PM -0400, Sasha Levin wrote:
>> From: Josef Bacik <josef@toxicpanda.com>
>>
>> [ Upstream commit 932fd26df8125a5b14438563c4d3e33f59ba80f7 ]
>>
>> We look up the fs root in various places in here when recovering from a
>> crashed relcoation. Make sure we hold a ref on the root whenever we
>> look them up.
>>
>> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
>> Reviewed-by: David Sterba <dsterba@suse.com>
>> Signed-off-by: David Sterba <dsterba@suse.com>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>Please drop this patch from all stable versions. It's part of a
>larger series that is preparatory switching from SRCU to refcounts, so
>the patch on itself does not fix anything.

I've dropped it, thanks!

--
Thanks,
Sasha