Re: [PATCH AUTOSEL 5.6 056/149] sh_eth: check sh_eth_cpu_data::no_xdfar when dumping registers

Sergei Shtylyov
2020-04-12T09:30:24Z

Hello!

On 12.04.2020 2:02, Sasha Levin wrote:

> From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> [ Upstream commit 7bf47f609f7eaac4f7e9c407a85ad78997288a38 ]
>
> When adding the sh_eth_cpu_data::no_xdfar flag I forgot to add the flag
> check to __sh_eth_get_regs(), causing the non-existing RDFAR/TDFAR to be
> considered for dumping on the R-Car gen1/2 SoCs (the register offset check
> has the final say here)...
>
> Fixes: 4c1d45850d5 ("sh_eth: add sh_eth_cpu_data::cexcr flag")

Oops, wrong commit here, should've been:

Fixes: 6e80e55bd37a ("sh_eth: add sh_eth_cpu_data::no_xdfar flag")

Luckily, both commits appeared in the same version, 4.17. :-)

> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Tested-by: Chris Brandt <chris.brandt@renesas.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
[...]

MBR, Sergei