From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA3ADC2BB86 for ; Sat, 11 Apr 2020 23:47:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6E3F20787 for ; Sat, 11 Apr 2020 23:47:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586648877; bh=70QxI/XnNG+p+hRvKqGo7LgBaeCOY62GcGH1duZbP6E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0ChkAm1yfO+MDGKuWhGSN+fh6gavjRo43LWEQCkIcShLg835HPkrSbL4HEFEuM4PI grP4AKj44pOCKPpwRrKA0oH1nNSXZAW9CdIcNP5TOcKWS41ikat46tp3Mj+97ra8XD mvJNNi3rbPyLbl2FV25x0XX5cOmc2Klc7sKn629M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727582AbgDKXEx (ORCPT ); Sat, 11 Apr 2020 19:04:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:38452 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727405AbgDKXEt (ORCPT ); Sat, 11 Apr 2020 19:04:49 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8C13E216FD; Sat, 11 Apr 2020 23:04:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586646289; bh=70QxI/XnNG+p+hRvKqGo7LgBaeCOY62GcGH1duZbP6E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IbvQyFPi9Uvl5GUv2a2+KOAe4Ao4ZhuEWB5hKY+PzJF4QM/WqXdbLfFO4KIEpq3fc h522PBGVwzTShzXyPJFTizAUB002uMxK4JnOMev3BxY5iOQ16wP54H/8+h+7zslSx/ rAF0Ndd+OZmgM8ld7NpH4YDuthqiGB5P83y9klgs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Guangbin Huang , Huazhong Tan , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.6 050/149] net: hns3: modify an unsuitable print when setting unknown duplex to fibre Date: Sat, 11 Apr 2020 19:02:07 -0400 Message-Id: <20200411230347.22371-50-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200411230347.22371-1-sashal@kernel.org> References: <20200411230347.22371-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guangbin Huang [ Upstream commit 2d3db26d78805c9e06e26def0081c76e9bb0b7d6 ] Currently, if device is in link down status and user uses 'ethtool -s' command to set speed but not specify duplex mode, the duplex mode passed from ethtool to driver is unknown value(255), and the fibre port will identify this value as half duplex mode and print "only copper port supports half duplex!". This message is confusing. So for fibre port, only the setting duplex is half, prints error and returns. Signed-off-by: Guangbin Huang Signed-off-by: Huazhong Tan Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c index c03856e633202..3f59a1924390f 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c @@ -736,7 +736,7 @@ static int hns3_check_ksettings_param(const struct net_device *netdev, if (ops->get_media_type) ops->get_media_type(handle, &media_type, &module_type); - if (cmd->base.duplex != DUPLEX_FULL && + if (cmd->base.duplex == DUPLEX_HALF && media_type != HNAE3_MEDIA_TYPE_COPPER) { netdev_err(netdev, "only copper port supports half duplex!"); -- 2.20.1