From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77D0EC2BA19 for ; Sat, 11 Apr 2020 23:45:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4595C20936 for ; Sat, 11 Apr 2020 23:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586648712; bh=HNRvMUw/kLezJdIoz9O9MmRcK4JLCtZ1/pjIhz6o6wU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=foRK6mY5f7BnrJ3HJiBCisFX/vFUMgLdgqvylS1qDE5tERfA0db1M3mbr8HF3CRcI WKeqD32WR7KbPtAET+Lojd/JFyQmbnRdPgkonC+NZnmbmur5gBFduHmjFxeGs5TWdp vPxiykoElKBNy2iMG4T5pXW1wtz3LMZ+lELrpBsM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728399AbgDKXpK (ORCPT ); Sat, 11 Apr 2020 19:45:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:40348 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728061AbgDKXFr (ORCPT ); Sat, 11 Apr 2020 19:05:47 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6F66F214D8; Sat, 11 Apr 2020 23:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586646347; bh=HNRvMUw/kLezJdIoz9O9MmRcK4JLCtZ1/pjIhz6o6wU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AHe745jYzxE/V/mdvhDe5dVFvX4HmerwjGNu3muIgcvXkaaD3Fw11rufYWBId/vvf S/2aa4/BLb5Twq853SmsJq/znFttc7pBnkbTKNJ17i1hMbG3IeSx159ohV5lUToNfL JkYOL75QsmzSzW5lsL4FwaZlhA5Su7AvLBV1l13s= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Nicholas Kazlauskas , Alex Deucher , Sasha Levin , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.6 095/149] drm/amd/display: Fix dmub_psr_destroy() Date: Sat, 11 Apr 2020 19:02:52 -0400 Message-Id: <20200411230347.22371-95-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200411230347.22371-1-sashal@kernel.org> References: <20200411230347.22371-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit e599f01f44a77578c43530b027886933d9d2bb5b ] This is freeing the wrong variable so it will crash. It should be freeing "*dmub" instead of "dmub". Fixes: 4c1a1335dfe0 ("drm/amd/display: Driverside changes to support PSR in DMCUB") Reviewed-by: Nicholas Kazlauskas Signed-off-by: Dan Carpenter Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c index 225955ec6d392..5fd3b59f183b7 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c @@ -215,6 +215,6 @@ struct dmub_psr *dmub_psr_create(struct dc_context *ctx) */ void dmub_psr_destroy(struct dmub_psr **dmub) { - kfree(dmub); + kfree(*dmub); *dmub = NULL; } -- 2.20.1