From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7429C2BA19 for ; Sat, 11 Apr 2020 23:32:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A72AC206E9 for ; Sat, 11 Apr 2020 23:32:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586647964; bh=feWiSaDs4TCqbLvcliEgFp07dy9mV1+go9/DXaD0w8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=DwWktaGZIPZCYLqAu/nWCP/cvMAHdu0OY3zC+LGPnEchKVpGYMlocIsx+JN08f/5Z Mf5IzjtlB3Tjl49kBfnZjMcCWE4RyBOP3T44fHPhaZV2/P/3ZCBt74gSfw0L3ajfal 2jamPn5tquvyvtmG7Cjez3l0fkkOcEpRFvpuCvfw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729712AbgDKXcm (ORCPT ); Sat, 11 Apr 2020 19:32:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:47970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729393AbgDKXJ7 (ORCPT ); Sat, 11 Apr 2020 19:09:59 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4563320787; Sat, 11 Apr 2020 23:09:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586646600; bh=feWiSaDs4TCqbLvcliEgFp07dy9mV1+go9/DXaD0w8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RkEkOyBu5Xe9nAVsmkTVkjZ3TIsEplzBlQqDBV5zqaz/xgRBhbhJTLnIt/v4JmTmm 8oufQyXyQFt7bsWCKJ6qg4EVXgNzg50zJ28pRCDigMNHhddo4GIAhC+CQywUCdEOgi 3pk2EWPjrGjAbS39GcFOi6py5gZj6sfpByR1/gKs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jason Gunthorpe , Selvin Xavier , Sasha Levin , linux-rdma@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 013/108] RDMA/bnxt_re: Fix lifetimes in bnxt_re_task Date: Sat, 11 Apr 2020 19:08:08 -0400 Message-Id: <20200411230943.24951-13-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200411230943.24951-1-sashal@kernel.org> References: <20200411230943.24951-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jason Gunthorpe [ Upstream commit 8a6c61704746d3a1e004e054504ae8d98ed95697 ] A work queue cannot just rely on the ib_device not being freed, it must hold a kref on the memory so that the BNXT_RE_FLAG_IBDEV_REGISTERED check works. Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver") Link: https://lore.kernel.org/r/1584117207-2664-3-git-send-email-selvin.xavier@broadcom.com Signed-off-by: Selvin Xavier Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/bnxt_re/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c index 27e2df44d043d..cf51f2606877c 100644 --- a/drivers/infiniband/hw/bnxt_re/main.c +++ b/drivers/infiniband/hw/bnxt_re/main.c @@ -1584,6 +1584,7 @@ static void bnxt_re_task(struct work_struct *work) smp_mb__before_atomic(); atomic_dec(&rdev->sched_count); exit: + put_device(&rdev->ibdev.dev); kfree(re_work); } @@ -1660,6 +1661,7 @@ static int bnxt_re_netdev_event(struct notifier_block *notifier, /* Allocate for the deferred task */ re_work = kzalloc(sizeof(*re_work), GFP_ATOMIC); if (re_work) { + get_device(&rdev->ibdev.dev); re_work->rdev = rdev; re_work->event = event; re_work->vlan_dev = (real_dev == netdev ? -- 2.20.1