From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB35BC2BA19 for ; Sat, 11 Apr 2020 23:11:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7692621744 for ; Sat, 11 Apr 2020 23:11:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586646703; bh=R2jZ2+8UiQo4UPZjj2tDin5/Lvsu8Ax4oUlcXeMn4YU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=To8K8B8Gy7oqzlNyLMWy6xNbdy7Fd+m2r+mI9pCuf3Si0/Tvm9vS3NuUhIo6hfiOL Gvyw09QVA/go3hT9ihrJvK0LpO+RRBDlRHpyDZhX7SPz9w31qHRkTSKc5gbhZVhYBZ ewkwxxq4/+UiECLZX7VaegFvd9w9XdfVp4z9IIuI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729981AbgDKXLm (ORCPT ); Sat, 11 Apr 2020 19:11:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:51160 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729233AbgDKXLa (ORCPT ); Sat, 11 Apr 2020 19:11:30 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C2C9C20757; Sat, 11 Apr 2020 23:11:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586646690; bh=R2jZ2+8UiQo4UPZjj2tDin5/Lvsu8Ax4oUlcXeMn4YU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ORRR6+Uy4M4Ir+12Jvam+F9A+nvbucjJb7yYigwzrnt00kKIgWvzw2v12orZmYx08 N3BOtsoXnb0uJp+rwv0l7FjjKiBTUJYpPYK5ejDqzS968T3wMOwIA8K2ThP+ERiqRZ 6RmbQsRlEBaJUT6OdNMZ/gvXh4+TTfrASRx6isZE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Olivier Moysan , Mark Brown , Sasha Levin , alsa-devel@alsa-project.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 085/108] ASoC: stm32: spdifrx: fix regmap status check Date: Sat, 11 Apr 2020 19:09:20 -0400 Message-Id: <20200411230943.24951-85-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200411230943.24951-1-sashal@kernel.org> References: <20200411230943.24951-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Olivier Moysan [ Upstream commit a168dae5ea14283e8992d5282237bb0d6a3e1c06 ] Release resources when exiting on error. Fixes: 1a5c0b28fc56 ("ASoC: stm32: spdifrx: manage identification registers") Signed-off-by: Olivier Moysan Link: https://lore.kernel.org/r/20200318144125.9163-2-olivier.moysan@st.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/stm/stm32_spdifrx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/stm/stm32_spdifrx.c b/sound/soc/stm/stm32_spdifrx.c index e53fb4bd66b36..9fc2a1767eb1d 100644 --- a/sound/soc/stm/stm32_spdifrx.c +++ b/sound/soc/stm/stm32_spdifrx.c @@ -995,6 +995,8 @@ static int stm32_spdifrx_probe(struct platform_device *pdev) if (idr == SPDIFRX_IPIDR_NUMBER) { ret = regmap_read(spdifrx->regmap, STM32_SPDIFRX_VERR, &ver); + if (ret) + goto error; dev_dbg(&pdev->dev, "SPDIFRX version: %lu.%lu registered\n", FIELD_GET(SPDIFRX_VERR_MAJ_MASK, ver), -- 2.20.1