From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97607C2BBFD for ; Sat, 11 Apr 2020 23:25:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 670FC2051A for ; Sat, 11 Apr 2020 23:25:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586647536; bh=W7VnBqQ9i2QUugSwTZtkTKCZP7hS8z2gJQJI/uzXQ54=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vvLd87/Zvcli9CKgEG9465EeqQHXoYseukYrQND+RjYS023Bubql3WmgbKfNORDic WEfTsG+zM7nL3YoslpzCUAjpQ3f6f0Z8al+leeGvzLM2Kn+lLVx3GWBudV1iX9if2v UgrH5e/RIMtzNNP3ijQx+44fy2FbPcEpZzeav6sk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730101AbgDKXMM (ORCPT ); Sat, 11 Apr 2020 19:12:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:52056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730075AbgDKXMJ (ORCPT ); Sat, 11 Apr 2020 19:12:09 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5024F216FD; Sat, 11 Apr 2020 23:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586646729; bh=W7VnBqQ9i2QUugSwTZtkTKCZP7hS8z2gJQJI/uzXQ54=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GE0sDsLoyt9e1PXHjXnqoCPzbYVbqpMhb5MklXFd/wnsq6aY52/+yJJdxuUj42I9K 1Vtzxr3QWBiTEJL34hdjlf0IBpWaBweUtxMVHChl7xlvdmorbbDY+sWgXm1NT4Fmu0 s2XocGSe/N+k9FuGoGdMiwFeGw14ar3bzA6nZRmw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Haibo Chen , Adrian Hunter , Linus Walleij , Ulf Hansson , Sasha Levin , linux-mmc@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 04/66] mmc: sdhci: do not enable card detect interrupt for gpio cd type Date: Sat, 11 Apr 2020 19:11:01 -0400 Message-Id: <20200411231203.25933-4-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200411231203.25933-1-sashal@kernel.org> References: <20200411231203.25933-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haibo Chen [ Upstream commit e65bb38824711559844ba932132f417bc5a355e2 ] Except SDHCI_QUIRK_BROKEN_CARD_DETECTION and MMC_CAP_NONREMOVABLE, we also do not need to handle controller native card detect interrupt for gpio cd type. If we wrong enabled the card detect interrupt for gpio case, it will cause a lot of unexpected card detect interrupts during data transfer which should not happen. Signed-off-by: Haibo Chen Acked-by: Adrian Hunter Reviewed-by: Linus Walleij Link: https://lore.kernel.org/r/1582100563-20555-2-git-send-email-haibo.chen@nxp.com Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/host/sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 5a7fd89a8f2b1..499a3d2a8e315 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -133,7 +133,7 @@ static void sdhci_set_card_detection(struct sdhci_host *host, bool enable) u32 present; if ((host->quirks & SDHCI_QUIRK_BROKEN_CARD_DETECTION) || - !mmc_card_is_removable(host->mmc)) + !mmc_card_is_removable(host->mmc) || mmc_can_gpio_cd(host->mmc)) return; if (enable) { -- 2.20.1