From: Krzysztof Kozlowski <krzk@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Takashi Iwai <tiwai@suse.de>, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Sangbeom Kim <sbkim73@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>
Subject: Re: ASoC: s3c-i2s-v2 regression, was: [GIT PULL] sound updates for 5.6-rc1
Date: Mon, 13 Apr 2020 14:15:30 +0200 [thread overview]
Message-ID: <20200413121530.GA5200@kozik-lap> (raw)
In-Reply-To: <CAK8P3a1La1gbSp0A9JaQ5KavGELQ8NsKQvCdAdya24agJzTOJA@mail.gmail.com>
On Sat, Apr 11, 2020 at 10:41:52AM +0200, Arnd Bergmann wrote:
> On Tue, Jan 28, 2020 at 9:21 AM Takashi Iwai <tiwai@suse.de> wrote:
>
> > Kuninori Morimoto (66):
> > ASoC: bcm: cygnus-ssp: move .suspend/.resume to component
> > ASoC: atmel: atmel_ssc_dai: move .suspend/.resume to component
> > ASoC: cirrus: ep93xx-i2s: move .suspend/.resume to component
> > ASoC: jz4740: jz4740-i2s: move .suspend/.resume to component
> > ASoC: mediatek: move .suspend/.resume to component
> > ASoC: samsung: s3c24xx-i2s: move .suspend/.resume to component
> > ASoC: samsung: spdif: move .suspend/.resume to component
> > ASoC: sti: sti_uniperif: move .suspend/.resume to component
> > ASoC: ti: omap-mcpdm: move .suspend/.resume to component
> > ASoC: uniphier: move .suspend/.resume to component
> > ASoC: dwc: dwc-i2s: move .suspend/.resume to component
> > ASoC: samsung: i2s: move .suspend/.resume to component
> > ASoC: ux500: ux500_msp_dai: remove unused DAI .suspend/.resume
> > ASoC: pxa: pxa-ssp: move .suspend/.resume to component
> > ASoC: pxa: pxa2xx-i2s: move .suspend/.resume to component
> > ASoC: soc-core: remove DAI suspend/resume
>
> I only found it now during randconfig testing, but it seems that there is
> (at least) one patching in this conversion series that was part of linux-5.6:
>
> sound/soc/samsung/s3c-i2s-v2.c: In function 's3c_i2sv2_register_component':
> sound/soc/samsung/s3c-i2s-v2.c:726:9: error: 'struct
> snd_soc_dai_driver' has no member named 'suspend'
> 726 | dai_drv->suspend = s3c2412_i2s_suspend;
> | ^~
> sound/soc/samsung/s3c-i2s-v2.c:727:9: error: 'struct
> snd_soc_dai_driver' has no member named 'resume'
> 727 | dai_drv->resume = s3c2412_i2s_resume;
> | ^~
>
> I tried fixing it myself but could not see an obvious solution. Can someone
> else who understands this code better than me have a look?
This can be triggered after enabling SND_SOC_SAMSUNG and
SND_SOC_SAMSUNG_JIVE_WM8750.
I can fix it but only compile-tested.
Best regards,
Krzysztof
prev parent reply other threads:[~2020-04-13 12:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 8:19 [GIT PULL] sound updates for 5.6-rc1 Takashi Iwai
2020-01-29 0:35 ` pr-tracker-bot
2020-04-11 8:41 ` ASoC: s3c-i2s-v2 regression, was: " Arnd Bergmann
2020-04-13 12:15 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413121530.GA5200@kozik-lap \
--to=krzk@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox