From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Jason Yan <yanaijie@huawei.com>
Cc: suzuki.poulose@arm.com, mike.leach@linaro.org,
alexander.shishkin@linux.intel.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] coresight: etb10: make coresight_etb_groups static
Date: Mon, 13 Apr 2020 11:59:15 -0600 [thread overview]
Message-ID: <20200413175915.GF28804@xps15> (raw)
In-Reply-To: <20200413082237.23177-1-yanaijie@huawei.com>
On Mon, Apr 13, 2020 at 04:22:37PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
>
> drivers/hwtracing/coresight/coresight-etb10.c:720:30: warning: symbol
> 'coresight_etb_groups' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/hwtracing/coresight/coresight-etb10.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c
> index 3810290e6d07..03e3f2590191 100644
> --- a/drivers/hwtracing/coresight/coresight-etb10.c
> +++ b/drivers/hwtracing/coresight/coresight-etb10.c
> @@ -717,7 +717,7 @@ static const struct attribute_group coresight_etb_mgmt_group = {
> .name = "mgmt",
> };
>
> -const struct attribute_group *coresight_etb_groups[] = {
> +static const struct attribute_group *coresight_etb_groups[] = {
> &coresight_etb_group,
> &coresight_etb_mgmt_group,
> NULL,
Applied - thanks,
Mathieu
> --
> 2.21.1
>
prev parent reply other threads:[~2020-04-13 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 8:22 [PATCH] coresight: etb10: make coresight_etb_groups static Jason Yan
2020-04-13 17:59 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413175915.GF28804@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=hulkci@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox