[regression 5.7-rc1] System does not power off, just halts

[regression 5.7-rc1] System does not power off, just halts

[Paul Menzel]

Dear Linux folks,


A regression between causes a system with the AMD board MSI B350M MORTAR 
(MS-7A37) with an AMD Ryzen 3 2200G not to power off any more but just 
to halt.

The regression is introduced in 9ebe5422ad6c..b032227c6293. I am in the 
process to bisect this, but maybe somebody already has an idea.


Kind regards,

Paul

Re: [regression 5.7-rc1] System does not power off, just halts

[Paul Menzel]

Dear Prike, dear Alex, dear Linux folks,


Am 13.04.20 um 10:44 schrieb Paul Menzel:

> A regression between causes a system with the AMD board MSI B350M MORTAR 
> (MS-7A37) with an AMD Ryzen 3 2200G not to power off any more but just 
> to halt.
> 
> The regression is introduced in 9ebe5422ad6c..b032227c6293. I am in the 
> process to bisect this, but maybe somebody already has an idea.

I found the Easter egg:

> commit 487eca11a321ef33bcf4ca5adb3c0c4954db1b58
> Author: Prike Liang <Prike.Liang@amd.com>
> Date:   Tue Apr 7 20:21:26 2020 +0800
> 
>     drm/amdgpu: fix gfx hang during suspend with video playback (v2)
>     
>     The system will be hang up during S3 suspend because of SMU is pending
>     for GC not respose the register CP_HQD_ACTIVE access request.This issue
>     root cause of accessing the GC register under enter GFX CGGPG and can
>     be fixed by disable GFX CGPG before perform suspend.
>     
>     v2: Use disable the GFX CGPG instead of RLC safe mode guard.
>     
>     Signed-off-by: Prike Liang <Prike.Liang@amd.com>
>     Tested-by: Mengbing Wang <Mengbing.Wang@amd.com>
>     Reviewed-by: Huang Rui <ray.huang@amd.com>
>     Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>     Cc: stable@vger.kernel.org

It reverts cleanly on top of 5.7-rc1, and this fixes the issue.

Greg, please do not apply this to the stable series. The commit message 
doesn’t even reference a issue/bug report, and doesn’t give a detailed 
problem description. What system is it?

Dave, Alex, how to proceed? Revert? I created issue 1094 [1].


Kind regards,

Paul


[1]: https://gitlab.freedesktop.org/drm/amd/-/issues/1094

Re: [regression 5.7-rc1] System does not power off, just halts

[Alex Deucher]

On Mon, Apr 13, 2020 at 1:47 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Dear Prike, dear Alex, dear Linux folks,
>
>
> Am 13.04.20 um 10:44 schrieb Paul Menzel:
>
> > A regression between causes a system with the AMD board MSI B350M MORTAR
> > (MS-7A37) with an AMD Ryzen 3 2200G not to power off any more but just
> > to halt.
> >
> > The regression is introduced in 9ebe5422ad6c..b032227c6293. I am in the
> > process to bisect this, but maybe somebody already has an idea.
>
> I found the Easter egg:
>
> > commit 487eca11a321ef33bcf4ca5adb3c0c4954db1b58
> > Author: Prike Liang <Prike.Liang@amd.com>
> > Date:   Tue Apr 7 20:21:26 2020 +0800
> >
> >     drm/amdgpu: fix gfx hang during suspend with video playback (v2)
> >
> >     The system will be hang up during S3 suspend because of SMU is pending
> >     for GC not respose the register CP_HQD_ACTIVE access request.This issue
> >     root cause of accessing the GC register under enter GFX CGGPG and can
> >     be fixed by disable GFX CGPG before perform suspend.
> >
> >     v2: Use disable the GFX CGPG instead of RLC safe mode guard.
> >
> >     Signed-off-by: Prike Liang <Prike.Liang@amd.com>
> >     Tested-by: Mengbing Wang <Mengbing.Wang@amd.com>
> >     Reviewed-by: Huang Rui <ray.huang@amd.com>
> >     Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> >     Cc: stable@vger.kernel.org
>
> It reverts cleanly on top of 5.7-rc1, and this fixes the issue.
>
> Greg, please do not apply this to the stable series. The commit message
> doesn’t even reference a issue/bug report, and doesn’t give a detailed
> problem description. What system is it?
>
> Dave, Alex, how to proceed? Revert? I created issue 1094 [1].

Already fixed:
https://patchwork.freedesktop.org/patch/361195/

Alex

>
>
> Kind regards,
>
> Paul
>
>
> [1]: https://gitlab.freedesktop.org/drm/amd/-/issues/1094
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [regression 5.7-rc1] System does not power off, just halts

[Greg KH]

On Mon, Apr 13, 2020 at 01:48:58PM -0400, Alex Deucher wrote:
> On Mon, Apr 13, 2020 at 1:47 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
> >
> > Dear Prike, dear Alex, dear Linux folks,
> >
> >
> > Am 13.04.20 um 10:44 schrieb Paul Menzel:
> >
> > > A regression between causes a system with the AMD board MSI B350M MORTAR
> > > (MS-7A37) with an AMD Ryzen 3 2200G not to power off any more but just
> > > to halt.
> > >
> > > The regression is introduced in 9ebe5422ad6c..b032227c6293. I am in the
> > > process to bisect this, but maybe somebody already has an idea.
> >
> > I found the Easter egg:
> >
> > > commit 487eca11a321ef33bcf4ca5adb3c0c4954db1b58
> > > Author: Prike Liang <Prike.Liang@amd.com>
> > > Date:   Tue Apr 7 20:21:26 2020 +0800
> > >
> > >     drm/amdgpu: fix gfx hang during suspend with video playback (v2)
> > >
> > >     The system will be hang up during S3 suspend because of SMU is pending
> > >     for GC not respose the register CP_HQD_ACTIVE access request.This issue
> > >     root cause of accessing the GC register under enter GFX CGGPG and can
> > >     be fixed by disable GFX CGPG before perform suspend.
> > >
> > >     v2: Use disable the GFX CGPG instead of RLC safe mode guard.
> > >
> > >     Signed-off-by: Prike Liang <Prike.Liang@amd.com>
> > >     Tested-by: Mengbing Wang <Mengbing.Wang@amd.com>
> > >     Reviewed-by: Huang Rui <ray.huang@amd.com>
> > >     Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> > >     Cc: stable@vger.kernel.org
> >
> > It reverts cleanly on top of 5.7-rc1, and this fixes the issue.
> >
> > Greg, please do not apply this to the stable series. The commit message
> > doesn’t even reference a issue/bug report, and doesn’t give a detailed
> > problem description. What system is it?
> >
> > Dave, Alex, how to proceed? Revert? I created issue 1094 [1].
> 
> Already fixed:
> https://patchwork.freedesktop.org/patch/361195/

Any reason that doesn't have a cc: stable tag on it?

And is it committed to any tree at the moment?

thanks,

greg k-h

Re: [regression 5.7-rc1] System does not power off, just halts

[Alex Deucher]

On Tue, Apr 14, 2020 at 4:21 AM Greg KH <greg@kroah.com> wrote:
>
> On Mon, Apr 13, 2020 at 01:48:58PM -0400, Alex Deucher wrote:
> > On Mon, Apr 13, 2020 at 1:47 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
> > >
> > > Dear Prike, dear Alex, dear Linux folks,
> > >
> > >
> > > Am 13.04.20 um 10:44 schrieb Paul Menzel:
> > >
> > > > A regression between causes a system with the AMD board MSI B350M MORTAR
> > > > (MS-7A37) with an AMD Ryzen 3 2200G not to power off any more but just
> > > > to halt.
> > > >
> > > > The regression is introduced in 9ebe5422ad6c..b032227c6293. I am in the
> > > > process to bisect this, but maybe somebody already has an idea.
> > >
> > > I found the Easter egg:
> > >
> > > > commit 487eca11a321ef33bcf4ca5adb3c0c4954db1b58
> > > > Author: Prike Liang <Prike.Liang@amd.com>
> > > > Date:   Tue Apr 7 20:21:26 2020 +0800
> > > >
> > > >     drm/amdgpu: fix gfx hang during suspend with video playback (v2)
> > > >
> > > >     The system will be hang up during S3 suspend because of SMU is pending
> > > >     for GC not respose the register CP_HQD_ACTIVE access request.This issue
> > > >     root cause of accessing the GC register under enter GFX CGGPG and can
> > > >     be fixed by disable GFX CGPG before perform suspend.
> > > >
> > > >     v2: Use disable the GFX CGPG instead of RLC safe mode guard.
> > > >
> > > >     Signed-off-by: Prike Liang <Prike.Liang@amd.com>
> > > >     Tested-by: Mengbing Wang <Mengbing.Wang@amd.com>
> > > >     Reviewed-by: Huang Rui <ray.huang@amd.com>
> > > >     Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> > > >     Cc: stable@vger.kernel.org
> > >
> > > It reverts cleanly on top of 5.7-rc1, and this fixes the issue.
> > >
> > > Greg, please do not apply this to the stable series. The commit message
> > > doesn’t even reference a issue/bug report, and doesn’t give a detailed
> > > problem description. What system is it?
> > >
> > > Dave, Alex, how to proceed? Revert? I created issue 1094 [1].
> >
> > Already fixed:
> > https://patchwork.freedesktop.org/patch/361195/
>
> Any reason that doesn't have a cc: stable tag on it?
>
> And is it committed to any tree at the moment?

It's going out in my -fixes pull this week with a stable tag.

Alex

>
> thanks,
>
> greg k-h