public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-acpi@vger.kernel.org,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	platform-driver-x86@vger.kernel.org,
	Darren Hart <dvhart@infradead.org>
Subject: Re: [PATCH v1 0/6] platform/x86: intel_cht_int33fe: clean up series
Date: Tue, 14 Apr 2020 15:31:07 +0300	[thread overview]
Message-ID: <20200414123107.GN34613@smile.fi.intel.com> (raw)
In-Reply-To: <9aa81292-70c2-c12a-ded1-1164faac0024@redhat.com>

On Tue, Apr 14, 2020 at 02:08:42PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 4/8/20 6:09 PM, Andy Shevchenko wrote:
> > When I started looking into the intel_cht_int33fe driver for an example of use
> > software node API, I have noticed that it's hard to get and code a bit messy.
> > Here is a clean up, main part of which is to introduce node groups and API to
> > register and unregister them. This and some pre-existing APIs can be used in
> > the driver.
> > 
> > So, because of cross-subsystem nature of this series, I may recommend to create
> > myself the immutable branch which can be pulled to Rafael's and Greg's trees
> > respectively. I'm also open for other proposals how to proceed.
> 
> The series looks good to me and I've also tested it on one of
> the devices using the intel_cht_int33fe driver and everything seems
> to work fine, so for the whole series:
> 
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> Tested-by: Hans de Goede <hdegoede@redhat.com>

Thank you, Hans!
I'll wait for Greg and Rafael to conclude how to proceed with it and maybe for
Heikki's response as well.

> > Andy Shevchenko (6):
> >    device property: export set_secondary_fwnode() to modules
> >    software node: Allow register and unregister software node groups
> >    platform/x86: intel_cht_int33fe: Convert software node array to group
> >    platform/x86: intel_cht_int33fe: Convert to use set_secondary_fwnode()
> >    platform/x86: intel_cht_int33fe: Switch to use
> >      acpi_dev_hid_uid_match()
> >    platform/x86: intel_cht_int33fe: Fix spelling issues
> > 
> >   drivers/base/core.c                           |   1 +
> >   drivers/base/swnode.c                         |  48 ++++++++
> >   .../platform/x86/intel_cht_int33fe_typec.c    | 106 +++++++++---------
> >   include/linux/property.h                      |   3 +
> >   4 files changed, 108 insertions(+), 50 deletions(-)

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2020-04-14 12:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08 16:09 [PATCH v1 0/6] platform/x86: intel_cht_int33fe: clean up series Andy Shevchenko
2020-04-08 16:09 ` [PATCH v1 1/6] device property: export set_secondary_fwnode() to modules Andy Shevchenko
2020-04-08 16:09 ` [PATCH v1 2/6] software node: Allow register and unregister software node groups Andy Shevchenko
2020-04-08 16:09 ` [PATCH v1 3/6] platform/x86: intel_cht_int33fe: Convert software node array to group Andy Shevchenko
2020-04-08 16:09 ` [PATCH v1 4/6] platform/x86: intel_cht_int33fe: Convert to use set_secondary_fwnode() Andy Shevchenko
2020-04-08 16:09 ` [PATCH v1 5/6] platform/x86: intel_cht_int33fe: Switch to use acpi_dev_hid_uid_match() Andy Shevchenko
2020-04-08 16:09 ` [PATCH v1 6/6] platform/x86: intel_cht_int33fe: Fix spelling issues Andy Shevchenko
2020-04-14 12:08 ` [PATCH v1 0/6] platform/x86: intel_cht_int33fe: clean up series Hans de Goede
2020-04-14 12:31   ` Andy Shevchenko [this message]
2020-04-14 12:17 ` Heikki Krogerus
2020-04-16 14:17 ` Andy Shevchenko
2020-04-16 15:03   ` Rafael J. Wysocki
2020-04-16 15:21     ` Andy Shevchenko
2020-04-18 19:43       ` Rafael J. Wysocki
2020-04-19  8:50         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200414123107.GN34613@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=dvhart@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox