From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41093C2BA19 for ; Tue, 14 Apr 2020 12:31:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23B2F206D5 for ; Tue, 14 Apr 2020 12:31:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2501977AbgDNMbL (ORCPT ); Tue, 14 Apr 2020 08:31:11 -0400 Received: from mga11.intel.com ([192.55.52.93]:9934 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730303AbgDNMbI (ORCPT ); Tue, 14 Apr 2020 08:31:08 -0400 IronPort-SDR: Iy9QSZDs70Ath6iSEz+L7OKl0uupYv9kCGWpnvlI3jOOF5yHKrF4CLR2TccrtvBvofGCTCE1u9 ld+EBvEcR/Bw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 05:31:07 -0700 IronPort-SDR: 2vvEyjfovcmuRN2989ozQVCdT6lttKyb06SarfZO7YOkpea33tAObZPt86LQm8lH1HlP0oGldn ni/MNf+4UEvA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,382,1580803200"; d="scan'208";a="241977020" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga007.jf.intel.com with ESMTP; 14 Apr 2020 05:31:05 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jOKiZ-000Wa9-MJ; Tue, 14 Apr 2020 15:31:07 +0300 Date: Tue, 14 Apr 2020 15:31:07 +0300 From: Andy Shevchenko To: Hans de Goede Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, Heikki Krogerus , platform-driver-x86@vger.kernel.org, Darren Hart Subject: Re: [PATCH v1 0/6] platform/x86: intel_cht_int33fe: clean up series Message-ID: <20200414123107.GN34613@smile.fi.intel.com> References: <20200408160905.12101-1-andriy.shevchenko@linux.intel.com> <9aa81292-70c2-c12a-ded1-1164faac0024@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9aa81292-70c2-c12a-ded1-1164faac0024@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 14, 2020 at 02:08:42PM +0200, Hans de Goede wrote: > Hi, > > On 4/8/20 6:09 PM, Andy Shevchenko wrote: > > When I started looking into the intel_cht_int33fe driver for an example of use > > software node API, I have noticed that it's hard to get and code a bit messy. > > Here is a clean up, main part of which is to introduce node groups and API to > > register and unregister them. This and some pre-existing APIs can be used in > > the driver. > > > > So, because of cross-subsystem nature of this series, I may recommend to create > > myself the immutable branch which can be pulled to Rafael's and Greg's trees > > respectively. I'm also open for other proposals how to proceed. > > The series looks good to me and I've also tested it on one of > the devices using the intel_cht_int33fe driver and everything seems > to work fine, so for the whole series: > > Reviewed-by: Hans de Goede > Tested-by: Hans de Goede Thank you, Hans! I'll wait for Greg and Rafael to conclude how to proceed with it and maybe for Heikki's response as well. > > Andy Shevchenko (6): > > device property: export set_secondary_fwnode() to modules > > software node: Allow register and unregister software node groups > > platform/x86: intel_cht_int33fe: Convert software node array to group > > platform/x86: intel_cht_int33fe: Convert to use set_secondary_fwnode() > > platform/x86: intel_cht_int33fe: Switch to use > > acpi_dev_hid_uid_match() > > platform/x86: intel_cht_int33fe: Fix spelling issues > > > > drivers/base/core.c | 1 + > > drivers/base/swnode.c | 48 ++++++++ > > .../platform/x86/intel_cht_int33fe_typec.c | 106 +++++++++--------- > > include/linux/property.h | 3 + > > 4 files changed, 108 insertions(+), 50 deletions(-) -- With Best Regards, Andy Shevchenko