From: Quentin Perret <qperret@google.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Luca Abeni <luca.abeni@santannapisa.it>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Wei Wang <wvw@google.com>, Alessio Balsini <balsini@google.com>,
Pavan Kondeti <pkondeti@codeaurora.org>,
Patrick Bellasi <patrick.bellasi@matbug.net>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Valentin Schneider <valentin.schneider@arm.com>,
Qais Yousef <qais.yousef@arm.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] sched/topology: Store root domain CPU capacity sum
Date: Tue, 14 Apr 2020 13:45:03 +0100 [thread overview]
Message-ID: <20200414124503.GA236568@google.com> (raw)
In-Reply-To: <CAKfTPtDS_qwPH+TwoFWPz6QRzG1N=t46ZvGN=w6zbOtnGAdOeQ@mail.gmail.com>
On Wednesday 08 Apr 2020 at 19:03:57 (+0200), Vincent Guittot wrote:
> Or we can do the opposite and only use capacity_orig_of()/rq->cpu_capacity_orig.
>
> Is there a case where the max cpu capacity changes over time ? So I
> would prefer to use cpu_capacity_orig which is a field of scheduler
> instead of always calling an external arch specific function
Note however that using arch_scale_cpu_capacity() would be more
efficient, especially on non-arm/arm64 systems where it is a
compile-time constant.
It's probably a matter of personal taste, but I find rq->cpu_capacity_orig
superfluous. It wastes space without actually giving you anything no?
Anybody remembers why it was introduced in the first place?
Thanks,
Quentin
next prev parent reply other threads:[~2020-04-14 12:45 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 9:50 [PATCH 0/4] Capacity awareness for SCHED_DEADLINE Dietmar Eggemann
2020-04-08 9:50 ` [PATCH 1/4] sched/topology: Store root domain CPU capacity sum Dietmar Eggemann
2020-04-08 12:29 ` Vincent Guittot
2020-04-08 16:30 ` Dietmar Eggemann
2020-04-08 17:03 ` Vincent Guittot
2020-04-09 13:50 ` Dietmar Eggemann
2020-04-09 14:13 ` Vincent Guittot
2020-04-14 9:20 ` Dietmar Eggemann
2020-04-14 12:45 ` Quentin Perret [this message]
2020-04-14 15:27 ` Dietmar Eggemann
2020-04-14 15:43 ` Vincent Guittot
2020-04-08 9:50 ` [PATCH 2/4] sched/deadline: Improve admission control for asymmetric CPU capacities Dietmar Eggemann
2020-04-08 10:42 ` Valentin Schneider
2020-04-08 12:26 ` Dietmar Eggemann
2020-04-08 13:30 ` luca abeni
2020-04-08 14:23 ` Qais Yousef
2020-04-08 15:01 ` Valentin Schneider
2020-04-09 17:29 ` Dietmar Eggemann
2020-04-14 11:40 ` Qais Yousef
2020-04-14 14:29 ` Valentin Schneider
2020-04-14 15:41 ` Qais Yousef
2020-04-14 14:28 ` Valentin Schneider
2020-04-17 12:19 ` Juri Lelli
2020-04-17 14:55 ` Dietmar Eggemann
2020-04-17 15:08 ` Juri Lelli
2020-04-17 15:47 ` Juri Lelli
2020-04-08 9:50 ` [PATCH 3/4] sched/deadline: Make DL capacity-aware Dietmar Eggemann
2020-04-10 12:52 ` Juri Lelli
2020-04-15 9:39 ` Dietmar Eggemann
2020-04-15 13:20 ` Juri Lelli
2020-04-15 16:42 ` luca abeni
2020-04-16 13:19 ` Juri Lelli
2020-04-08 9:50 ` [PATCH 4/4] sched/deadline: Implement fallback mechanism for !fit case Dietmar Eggemann
2020-04-09 10:25 ` Qais Yousef
2020-04-09 13:00 ` luca abeni
2020-04-09 14:55 ` Qais Yousef
2020-04-09 18:43 ` Dietmar Eggemann
2020-04-14 11:29 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414124503.GA236568@google.com \
--to=qperret@google.com \
--cc=balsini@google.com \
--cc=bristot@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=pkondeti@codeaurora.org \
--cc=qais.yousef@arm.com \
--cc=rostedt@goodmis.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=wvw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox