From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64DABC2BA19 for ; Tue, 14 Apr 2020 14:07:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BC6120578 for ; Tue, 14 Apr 2020 14:07:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="wtnfpDpq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388997AbgDNOHv (ORCPT ); Tue, 14 Apr 2020 10:07:51 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:36520 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388950AbgDNOHd (ORCPT ); Tue, 14 Apr 2020 10:07:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Apg7KSuzSoY9RJMbqt/rU+GxBZW+ZwBg4apqMt7/XV8=; b=wtnfpDpqG2O9AWbgb7SMqSg4br OXH3oXlLC0KnNsXtHWIjXODdRbV37oC5lrubW1D5KrNmFP42+0ATjqeio+0i6vMpt+zmIC2eTiaJT Vwwsj1jEI/ma0qYQxWnxEKXlliGPsiaVlrlDQPKWXYEo9uC6PoVjBaoBWGHLaHic94xw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jOMDq-002f8R-6R; Tue, 14 Apr 2020 16:07:30 +0200 Date: Tue, 14 Apr 2020 16:07:30 +0200 From: Andrew Lunn To: Florian Fainelli Cc: netdev@vger.kernel.org, Vivien Didelot , open list , davem@davemloft.net, kuba@kernel.org Subject: Re: [PATCH net 3/4] net: dsa: b53: Fix ARL register definitions Message-ID: <20200414140730.GL436020@lunn.ch> References: <20200414041630.5740-1-f.fainelli@gmail.com> <20200414041630.5740-4-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200414041630.5740-4-f.fainelli@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 13, 2020 at 09:16:29PM -0700, Florian Fainelli wrote: > The ARL {MAC,VID} tuple and the forward entry were off by 0x10 bytes, > which means that when we read/wrote from/to ARL bin index 0, we were > actually accessing the ARLA_RWCTRL register. > > Fixes: 1da6df85c6fb ("net: dsa: b53: Implement ARL add/del/dump operations") > Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn Andrew