public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com, Hans Verkuil <hverkuil@xs4all.nl>,
	Helen Koike <helen.koike@collabora.com>
Subject: Re: [PATCH] media: Kconfig: Don't expose API options
Date: Tue, 14 Apr 2020 15:26:31 +0200	[thread overview]
Message-ID: <20200414152631.7d1f1925@coco.lan> (raw)
In-Reply-To: <20200414152147.053b4b29@coco.lan>

Em Tue, 14 Apr 2020 15:21:47 +0200
Mauro Carvalho Chehab <mchehab@kernel.org> escreveu:

> Em Tue, 14 Apr 2020 10:02:10 -0300
> Ezequiel Garcia <ezequiel@collabora.com> escreveu:
> 
> > There is no need to expose API options; instead,
> > drivers that support a given API are expected to just select it.
> > 
> > Happily, this is currently the case, so simply stop
> > exposing the options.
> > 
> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > ---
> >  drivers/media/Kconfig           | 2 +-
> >  drivers/media/mc/Kconfig        | 3 +--
> >  drivers/media/v4l2-core/Kconfig | 2 +-
> >  3 files changed, 3 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> > index a8def1591352..eef4c6761ffb 100644
> > --- a/drivers/media/Kconfig
> > +++ b/drivers/media/Kconfig
> > @@ -173,7 +173,7 @@ config VIDEO_DEV
> >  	  radio devices and by some input devices.
> >  
> >  config MEDIA_CONTROLLER
> > -	bool "Media Controller API"
> > +	bool  
> 
> This is not true here... non-embedded drivers like DVB and UVC can work
> with or without the media controller. For them, the API is experimental.

Heh.... I meant to say:

	For them, the API is ***optional***.

Thanks,
Mauro

  reply	other threads:[~2020-04-14 13:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 13:02 [PATCH] media: Kconfig: Don't expose API options Ezequiel Garcia
2020-04-14 13:21 ` Mauro Carvalho Chehab
2020-04-14 13:26   ` Mauro Carvalho Chehab [this message]
2020-04-14 13:34   ` Ezequiel Garcia
2020-04-14 22:06 ` [PATCH] media: Kconfig: Don't expose the Request API option Ezequiel Garcia
2020-04-14 22:18   ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200414152631.7d1f1925@coco.lan \
    --to=mchehab+huawei@kernel.org \
    --cc=ezequiel@collabora.com \
    --cc=helen.koike@collabora.com \
    --cc=hverkuil@xs4all.nl \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox