From: Peter Zijlstra <peterz@infradead.org>
To: Mihai Carabas <mihai.carabas@oracle.com>
Cc: linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86: microcode: fix return value for microcode late loading
Date: Tue, 14 Apr 2020 18:22:21 +0200 [thread overview]
Message-ID: <20200414162221.GQ20713@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1586858135-29337-1-git-send-email-mihai.carabas@oracle.com>
On Tue, Apr 14, 2020 at 12:55:35PM +0300, Mihai Carabas wrote:
> The return value from stop_machine might not be consistent.
>
> stop_machine_cpuslocked returns:
> - zero if all functions have returned 0
> - a non-zero value if at least one of the functions returned
> a non-zero value
>
> There is no way to know if it is negative or positive. So make
> __reload_late return 0 on success, or negative otherwise.
>
> Signed-off-by: Mihai Carabas <mihai.carabas@oracle.com>
Isn't the right fix to disable late-loading?
next prev parent reply other threads:[~2020-04-14 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 9:55 [PATCH] x86: microcode: fix return value for microcode late loading Mihai Carabas
2020-04-14 16:22 ` Peter Zijlstra [this message]
2020-04-17 15:08 ` Borislav Petkov
2020-04-21 19:28 ` [PATCH v2] " Mihai Carabas
2020-04-22 18:04 ` [tip: x86/microcode] x86/microcode: Fix " tip-bot2 for Mihai Carabas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414162221.GQ20713@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.carabas@oracle.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox