Re: [PATCH v1] i2c: img-scb: remove duplicate dev_err()

Dejin Zheng
2020-04-14T15:51:10Z

On Tue, Apr 14, 2020 at 05:38:37PM +0300, Andy Shevchenko wrote:
> On Tue, Apr 14, 2020 at 10:26:50PM +0800, Dejin Zheng wrote:
> > it will print an error message by itself when platform_get_irq()
> > goes wrong. so don't need dev_err() in here again.
>
> In the future, please use something like this
> scripts/get_maintainer.pl --git --git-min-percent=67
> when retrieve Cc list for the mail.
>
Andy, Thank you for reminding me again, if I used it, There are only two
email addresses.

scripts/get_maintainer.pl --git --git-min-percent=67 v1-0001-i2c-img-scb-remove-duplicate-dev_err.patch
linux-i2c@vger.kernel.org (open list:I2C SUBSYSTEM HOST DRIVERS)
linux-kernel@vger.kernel.org (open list)

>
> FWIW,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
Thanks very much for your review.

BR,
Dejin

> > Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
> > ---
> > drivers/i2c/busses/i2c-img-scb.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-img-scb.c b/drivers/i2c/busses/i2c-img-scb.c
> > index 422097a31c95..2f6de763816a 100644
> > --- a/drivers/i2c/busses/i2c-img-scb.c
> > +++ b/drivers/i2c/busses/i2c-img-scb.c
> > @@ -1344,10 +1344,8 @@ static int img_i2c_probe(struct platform_device *pdev)
> > return PTR_ERR(i2c->base);
> >
> > irq = platform_get_irq(pdev, 0);
> > - if (irq < 0) {
> > - dev_err(&pdev->dev, "can't get irq number\n");
> > + if (irq < 0)
> > return irq;
> > - }
> >
> > i2c->sys_clk = devm_clk_get(&pdev->dev, "sys");
> > if (IS_ERR(i2c->sys_clk)) {
> > --
> > 2.25.0
> >
>
> --
> With Best Regards,
> Andy Shevchenko
>
>