Re: R: [PATCH v2 07/10] PCIe: qcom: fix init problem with missing PARF programming

Stanimir Varbanov
2020-04-08T13:18:07Z

Hi Ansuel,

On 4/8/20 3:38 PM, ansuelsmth@gmail.com wrote:
>> PARF programming
>>
>> Hi Ansuel,
>>
>> Please fix the patch subject for all patches in the series per Bjorn H.
>> request.
>>
>> PCI: qcom: Fix init problem with missing PARF programming
>>
>> Also the patch subject is misleading to me. Actually you change few phy
>> parameters: Tx De-Emphasis, Tx Swing and Rx equalization. On the other
>> side I guess those parameters are board specific and I'm not sure how
>> this change will reflect on apq8064 boards.
>>
>
> I also think that this would brake apq8064, on ipq8064 this is needed or
> the system doesn't boot.
> Should I move this to the dts and set this params only if they are present
> in dts or also here check for compatible and set accordingly?
>

I also think that these phy params should be per board (and they are
tunable).

Maybe you can propose those as generic phy params in pci.txt binding
document and then we can ask DT maintainers for opinion. If they refuse
such generic bindings, we could switch to custom qcom,phy properties.

--
regards,
Stan