From: Steven Rostedt <rostedt@goodmis.org>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: Markus Elfring <Markus.Elfring@web.de>,
<linux-kselftest@vger.kernel.org>,
<linux-trace-devel@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>,
Xiao Yang <ice_yangxiao@163.com>
Subject: Re: [PATCH v2] tracing: Fix the race between registering 'snapshot' event trigger and triggering 'snapshot' operation
Date: Tue, 14 Apr 2020 21:46:42 -0400 [thread overview]
Message-ID: <20200414214643.2e14ac76@oasis.local.home> (raw)
In-Reply-To: <5E966604.1020400@cn.fujitsu.com>
On Wed, 15 Apr 2020 09:40:20 +0800
Xiao Yang <yangx.jy@cn.fujitsu.com> wrote:
> On 2020/4/14 15:54, Markus Elfring wrote:
> >> Traced event can trigger 'snapshot' operation(i.e. calls snapshot_trigger()
> >
> > I suggest to improve the change description.
> >
> > * Adjustment:
> > … operation (i. e. …
> Hi Markus,
>
> Which part of description do you want to change or could you provide an
> example for reference?
That part is fine for me.
>
> >
> > * Will the tag “Fixes” become relevant?
>
> Do you mean to add the following "Fixes" tag?
> Fixes: 93e31ffbf417 "tracing: Add 'snapshot' event trigger command"
>
Yeah, that fixes tag is appropriate. But I usually add those myself, you
don't need to resend.
-- Steve
next prev parent reply other threads:[~2020-04-15 1:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 7:54 [PATCH v2] tracing: Fix the race between registering 'snapshot' event trigger and triggering 'snapshot' operation Markus Elfring
2020-04-15 1:40 ` Xiao Yang
2020-04-15 1:46 ` Steven Rostedt [this message]
2020-04-15 1:59 ` Xiao Yang
2020-04-15 7:12 ` [v2] " Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-04-14 1:51 [PATCH v2] " Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414214643.2e14ac76@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=Markus.Elfring@web.de \
--cc=ice_yangxiao@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox