From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1162C2BB1D for ; Tue, 14 Apr 2020 22:23:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC3012076B for ; Tue, 14 Apr 2020 22:23:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NHwXF7BN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387967AbgDNWXi (ORCPT ); Tue, 14 Apr 2020 18:23:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2387736AbgDNWXW (ORCPT ); Tue, 14 Apr 2020 18:23:22 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5840C061A0E for ; Tue, 14 Apr 2020 15:23:22 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id d17so590244pgo.0 for ; Tue, 14 Apr 2020 15:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UFTe4u5Y74nPDHZ96JTUPe7I2cuWzSZ7zVu37QG7nxg=; b=NHwXF7BNmRRnYfJyCE3haY1AahmmfCthI7mGWYzziRasWPI1YmJBTTV+5GuwfudtyF bR/8ac0TBsnDppONC+nXC5Xv6ALHiGO/+sOFJIrLZ8pnWqF6cd9rpy7x0/nViUJYloNp Ppx+0J+M1H4nuDt3iesHq8+ma07gHLcz5N/MUuANxDYsx17DK7sRQqoqzGhgQFQRaCiz 8MP4IENPPh0QviIFJXYCiJLhzWp3E9PDbTp4f4qESOZosVJ1cNFOrWbLYf0QKGF+K2ue 5PqACvbDOr29sgeIMpfhxMV4ufkul79aJmXeUvBbouuwHq+E5q+UX+ySwUZ7Cucm0ltl M74Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UFTe4u5Y74nPDHZ96JTUPe7I2cuWzSZ7zVu37QG7nxg=; b=I1j3LtUjA2JtVx6diMVT1e2+tg0eYamL1bPJSxecV3uSxZXuVCQBNeKu20955SGPOb VLaIBcij1gXOFMVeuZ6/kONR8gOZe4qusPsgEOBoQAImcGJUzbZWMeCB/wi5WGTWQMHP THsDOksAsxwARR/uT3yuhbC9lUJD44pctZvxGJxOtpVSUuMFr5dFQPRk06fnE0/SDHZl QdNOa0ecYsWYo3QtY+NtomeVtz6iq49oeko1nk2D0/cGnGAMxqzfNdG8iJh4WxzxthGf nlBOkwer6grc6vUMz512OnWaQ8uufRUhRawhXOl4uFFZQWyTxU5m7vinFHSIPrh7D5VQ SlKA== X-Gm-Message-State: AGi0PuaTtQhjARMv9iCVWYxE3be87fsAT6yEkv6LaLhNVLVXGePBRd3K wHyduCRtim6v0JnhJUaBuTY0xw== X-Google-Smtp-Source: APiQypITsjTqqYH98qq3TOSpyhUC81raNdwb1weMAeIKOc2+d9XkPYBJ7Nz0PeVpgu94Ae1bDoyfWA== X-Received: by 2002:a65:6910:: with SMTP id s16mr25161005pgq.426.1586903002149; Tue, 14 Apr 2020 15:23:22 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id y126sm6496046pgy.91.2020.04.14.15.23.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 15:23:21 -0700 (PDT) Date: Tue, 14 Apr 2020 15:23:37 -0700 From: Bjorn Andersson To: John Stultz Cc: lkml , Todd Kjos , Saravana Kannan , Andy Gross , Rajendra Nayak , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v3 2/3] soc: qcom: rpmh: Allow RPMH driver to be loaded as a module Message-ID: <20200414222337.GM576963@builder.lan> References: <20200326224459.105170-1-john.stultz@linaro.org> <20200326224459.105170-3-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200326224459.105170-3-john.stultz@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 26 Mar 15:44 PDT 2020, John Stultz wrote: > This patch allow the rpmh driver to be loaded as a permenent > module. Meaning it can be loaded from a module, but then cannot > be unloaded. > > Ideally, it would include a remove hook and related logic, but > the rpmh driver is fairly core to the system, so once its loaded > with almost anythign else to get the system to go, the dependencies > are not likely to ever also be removed. > > So making it a permenent module at least improves things slightly > over requiring it to be a built in driver. > > Feedback would be appreciated! > > Cc: Todd Kjos > Cc: Saravana Kannan > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Rajendra Nayak > Cc: linux-arm-msm@vger.kernel.org > Signed-off-by: John Stultz Reviewed-by: Bjorn Andersson and applied. Regards, Bjorn > --- > drivers/soc/qcom/Kconfig | 2 +- > drivers/soc/qcom/rpmh-rsc.c | 6 ++++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > index af774555b9d2..ac91eaf810f7 100644 > --- a/drivers/soc/qcom/Kconfig > +++ b/drivers/soc/qcom/Kconfig > @@ -104,7 +104,7 @@ config QCOM_RMTFS_MEM > Say y here if you intend to boot the modem remoteproc. > > config QCOM_RPMH > - bool "Qualcomm RPM-Hardened (RPMH) Communication" > + tristate "Qualcomm RPM-Hardened (RPMH) Communication" > depends on ARCH_QCOM && ARM64 || COMPILE_TEST > help > Support for communication with the hardened-RPM blocks in > diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c > index e278fc11fe5c..30585d98fdf1 100644 > --- a/drivers/soc/qcom/rpmh-rsc.c > +++ b/drivers/soc/qcom/rpmh-rsc.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -679,6 +680,8 @@ static const struct of_device_id rpmh_drv_match[] = { > { .compatible = "qcom,rpmh-rsc", }, > { } > }; > +MODULE_DEVICE_TABLE(of, rpmh_drv_match); > + > > static struct platform_driver rpmh_driver = { > .probe = rpmh_rsc_probe, > @@ -693,3 +696,6 @@ static int __init rpmh_driver_init(void) > return platform_driver_register(&rpmh_driver); > } > arch_initcall(rpmh_driver_init); > + > +MODULE_DESCRIPTION("Qualcomm Technologies, Inc. RPMh Driver"); > +MODULE_LICENSE("GPL v2"); > -- > 2.17.1 >