From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6CF8C2BB1D for ; Wed, 15 Apr 2020 00:07:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B53802076B for ; Wed, 15 Apr 2020 00:07:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586909243; bh=kX9vypy+m7pQaRNUL9aqUl2TFQjXB7+7PTmQ2YV4/2M=; h=From:To:Cc:Subject:Date:List-ID:From; b=K+RonULfKbhBrSP9MCbjRiEk+ucN1GXKieQslw2y3r+YK2d2+Rsbbm8Mps1/Ns+py NNVEiRRsOJUoSXEmNUMtJmDxlIkHQ3nucjshgV1G0b9akfhH8S2gXAMfk7Xzg4hBiI 9sFyT83e2kPUAwho6BLIrk5BScnTjyiEPKhfVndk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392252AbgDOAHR (ORCPT ); Tue, 14 Apr 2020 20:07:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:35366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392240AbgDOAG6 (ORCPT ); Tue, 14 Apr 2020 20:06:58 -0400 Received: from localhost (mobile-166-175-184-103.mycingular.net [166.175.184.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 84C722076B; Wed, 15 Apr 2020 00:06:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586909217; bh=kX9vypy+m7pQaRNUL9aqUl2TFQjXB7+7PTmQ2YV4/2M=; h=From:To:Cc:Subject:Date:From; b=gRO4dsLDyAqo+weACE5eZSSEfg08RLogdh6jLKlPDCPCEsVQztae7cK0OiGuUcwv9 ILh5pd8J1DFcWTdS4dxehzOA12fPjdELHxJpTzYVyI9DIFZp0ad1zhEo2RRgc9YIbA 7zRX6Jzi4WqRVzoNGL4Fyrd59AcE/GheFpD+Micc= From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, Bjorn Helgaas , Mika Westerberg Subject: [PATCH] PCI/PM: Call .bridge_d3() hook only if non-NULL Date: Tue, 14 Apr 2020 19:06:35 -0500 Message-Id: <20200415000635.144283-1-helgaas@kernel.org> X-Mailer: git-send-email 2.26.0.110.g2183baf09c-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Helgaas 26ad34d510a8 ("PCI / ACPI: Whitelist D3 for more PCIe hotplug ports") added the struct pci_platform_pm_ops.bridge_d3() function pointer and platform_pci_bridge_d3() to use it. The .bridge_d3() op is implemented by acpi_pci_platform_pm, but not by mid_pci_platform_pm. We don't expect platform_pci_bridge_d3() to be called on Intel MID platforms, but nothing in the code itself would prevent that. Check the .bridge_d3() pointer for NULL before calling it. Fixes: 26ad34d510a8 ("PCI / ACPI: Whitelist D3 for more PCIe hotplug ports") Signed-off-by: Bjorn Helgaas Cc: Mika Westerberg --- drivers/pci/pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 595fcf59843f..dfa7ec008963 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -868,7 +868,9 @@ static inline bool platform_pci_need_resume(struct pci_dev *dev) static inline bool platform_pci_bridge_d3(struct pci_dev *dev) { - return pci_platform_pm ? pci_platform_pm->bridge_d3(dev) : false; + if (pci_platform_pm && pci_platform_pm->bridge_d3) + return pci_platform_pm->bridge_d3(dev); + return false; } /** -- 2.26.0.110.g2183baf09c-goog