From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com, Hans Verkuil <hverkuil@xs4all.nl>,
Helen Koike <helen.koike@collabora.com>
Subject: Re: [PATCH] media: Kconfig: Don't expose the Request API option
Date: Wed, 15 Apr 2020 00:18:42 +0200 [thread overview]
Message-ID: <20200415001842.7773610b@coco.lan> (raw)
In-Reply-To: <20200414220624.5396-1-ezequiel@collabora.com>
Em Tue, 14 Apr 2020 19:06:24 -0300
Ezequiel Garcia <ezequiel@collabora.com> escreveu:
> The Request API isn't meant to be chosen by users,
> but instead should be selected by drivers that want
> to support it.
>
> Hantro and Cedrus are already selecting the right options,
> so only the test drivers need to be fixed.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
> drivers/media/mc/Kconfig | 6 ++++--
> drivers/media/test_drivers/Kconfig | 2 ++
> drivers/media/test_drivers/vicodec/Kconfig | 2 ++
> drivers/media/test_drivers/vivid/Kconfig | 2 ++
> 4 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/mc/Kconfig b/drivers/media/mc/Kconfig
> index 002a918c4c75..7c9628f37196 100644
> --- a/drivers/media/mc/Kconfig
> +++ b/drivers/media/mc/Kconfig
> @@ -2,7 +2,6 @@
>
> #
> # Media controller
> -# Selectable only for webcam/grabbers, as other drivers don't use it
> #
>
> config MEDIA_CONTROLLER_DVB
> @@ -14,7 +13,7 @@ config MEDIA_CONTROLLER_DVB
> This is currently experimental.
>
> config MEDIA_CONTROLLER_REQUEST_API
> - bool "Enable Media controller Request API (EXPERIMENTAL)"
> + bool
> depends on MEDIA_CONTROLLER && STAGING_MEDIA
> help
> DO NOT ENABLE THIS OPTION UNLESS YOU KNOW WHAT YOU'RE DOING.
Hmm... I guess you can also remove the help here, as it won't be
shown anymore with make menuconfig.
Thanks,
Mauro
prev parent reply other threads:[~2020-04-14 22:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 13:02 [PATCH] media: Kconfig: Don't expose API options Ezequiel Garcia
2020-04-14 13:21 ` Mauro Carvalho Chehab
2020-04-14 13:26 ` Mauro Carvalho Chehab
2020-04-14 13:34 ` Ezequiel Garcia
2020-04-14 22:06 ` [PATCH] media: Kconfig: Don't expose the Request API option Ezequiel Garcia
2020-04-14 22:18 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415001842.7773610b@coco.lan \
--to=mchehab@kernel.org \
--cc=ezequiel@collabora.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox