From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B8A1C3815B for ; Wed, 15 Apr 2020 11:17:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B44892076D for ; Wed, 15 Apr 2020 11:17:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="bGcv33xM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2896847AbgDOLQ4 (ORCPT ); Wed, 15 Apr 2020 07:16:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2896819AbgDOLN4 (ORCPT ); Wed, 15 Apr 2020 07:13:56 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 267ECC061A0C for ; Wed, 15 Apr 2020 04:13:41 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id o81so11338998wmo.2 for ; Wed, 15 Apr 2020 04:13:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=wvwCnQfvn/D3yTYVIatgF0Dj2nXBoxZoBca6sT2p9Rc=; b=bGcv33xMQLgfNtUOfjjcX4of7mEIfkiQSif2zJ1xLMHNR6H3M6UkD8UjGS34zeJ5yr HYge7lRmvFENxlm0cAq8O9U3eVhyv9V389VRaPQX7cIwZ/yqbQgnOa7pFmd8FBaLbt0o 4cg25hwscMQ1x9A9NldicpDAPR581llnFRQcc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=wvwCnQfvn/D3yTYVIatgF0Dj2nXBoxZoBca6sT2p9Rc=; b=HOZ695hPwplucldTGnZs5wAB5iXE4YVmF5XbwlAfywDJitXbEib6qFssx6jQN0acGZ scwCWsBYU2Ye3l8Q7IeJuZiUZIzi2N0ShhXE0uZ+hWg0VjEVnWv4cyAPG6wCuU+cSYft 7HZ7a2inu3EdGtVYgpdZwAawUKuPzNEk2b5H5BPk9keSbcwrTwGfwIGsU7jE94dpB7Vw bRmSzMWlSqIVSQ0vy62JCfKHefMrxQ8KA7GhGQjoY1BTx8Caab91gDPf0AbwMl6Cn9kl x2xTx1nakqqVVTllUdSVO6KyepGonvppi4fye2qpMUs7lV9BWQqqT9SkTk2UiWRzXV7G 9BPA== X-Gm-Message-State: AGi0PuYn8JOI/D8g4l0JE1wqwGiIGk223Xl6uwubNQ+dM10BCEEYu8jc /vM0yH9SaDLtueKi523QAvPtAw== X-Google-Smtp-Source: APiQypIahM+ZakKuCkW965ou0SjQzZmB10A4snEMgfEWVjOZaVHi9N4z5Cta4w/rqP+0WOLL49ymiw== X-Received: by 2002:a1c:4b0a:: with SMTP id y10mr4593858wma.24.1586949218840; Wed, 15 Apr 2020 04:13:38 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id q17sm14212238wmj.45.2020.04.15.04.13.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 04:13:37 -0700 (PDT) Date: Wed, 15 Apr 2020 13:13:36 +0200 From: Daniel Vetter To: Jani Nikula Cc: Yussuf Khalil , Daniel Vetter , Simon Ser , David Airlie , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Thomas Zimmermann Subject: Re: [PATCH 5/5] drm/i915: Replace "Broadcast RGB" with "RGB quantization range" property Message-ID: <20200415111336.GZ3456981@phenom.ffwll.local> Mail-Followup-To: Jani Nikula , Yussuf Khalil , Simon Ser , David Airlie , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Thomas Zimmermann References: <20200413214024.46500-1-dev@pp3345.net> <20200413214024.46500-6-dev@pp3345.net> <87ftd6mi3e.fsf@intel.com> <87d08amhy5.fsf@intel.com> <20200414123404.GT3456981@phenom.ffwll.local> <2cfe44c96818515939050ad19e9c248e50519be2.camel@pp3345.net> <87r1wp5hkq.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r1wp5hkq.fsf@intel.com> X-Operating-System: Linux phenom 5.3.0-3-amd64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2020 at 10:33:25AM +0300, Jani Nikula wrote: > On Tue, 14 Apr 2020, Yussuf Khalil wrote: > > On Tue, 2020-04-14 at 14:34 +0200, Daniel Vetter wrote: > >> On Tue, Apr 14, 2020 at 02:21:06PM +0300, Jani Nikula wrote: > >> > On Tue, 14 Apr 2020, Jani Nikula > >> > wrote: > >> > > On Mon, 13 Apr 2020, Simon Ser wrote: > >> > > > On Monday, April 13, 2020 11:40 PM, Yussuf Khalil < > >> > > > dev@pp3345.net> wrote: > >> > > > > >> > > > > DRM now has a globally available "RGB quantization range" > >> > > > > connector > >> > > > > property. i915's "Broadcast RGB" that fulfils the same > >> > > > > purpose is now > >> > > > > considered deprecated, so drop it in favor of the DRM > >> > > > > property. > >> > > > > >> > > > For a UAPI point-of-view, I'm not sure this is fine. Some user- > >> > > > space > >> > > > might depend on this property, dropping it would break such > >> > > > user-space. > >> > > > >> > > Agreed. > >> > > > >> > > > Can we make this property deprecated but still keep it for > >> > > > backwards > >> > > > compatibility? > >> > > > >> > > Would be nice to make the i915 specific property an "alias" for > >> > > the new > >> > > property, however I'm not sure how you'd make that happen. > >> > > Otherwise > >> > > juggling between the two properties is going to be a nightmare. > >> > > >> > Ah, the obvious easy choice is to use the property and enum names > >> > already being used by i915 and gma500, and you have no problem. > >> > Perhaps > >> > they're not the names you'd like, but then looking at the total > >> > lack of > >> > consistency across property naming makes them fit right in. ;) > >> > >> Yeah if we don't have contradictory usage across drivers when > >> modernizing > >> these properties, then let's just stick with the names already there. > >> It's > >> not pretty, but works better since more userspace/internet howtos > >> know how > >> to use this stuff. > >> -Daniel > > > > Note that i915's "Broadcast RGB" isn't the same as gma500's: i915 has an > > "Automatic" option, whereas gma500 does not. > > Adding "Automatic" option that just defaults to "Full" in gma500 does > not break existing userspace, but allows for extending it to do more > clever things later. gma500 could keep it's own property, without the "Automatic" value. We've done tricks like this for other properties too. > > Also, radeon has a property called > > "output_csc" that fulfills a similar purpose. Looking at the code, though, it > > seems that radeon does not adhere to the standard correctly (or I am missing > > something). > > > > An alternative would be to leave the existing driver-specific properties and > > change them to be pseudo-aliases for the "RGB quantization range" property. > > This can be done by letting the drivers read from and write to the new property > > when user-space tries to read or modify the driver's property. This way we could > > retain full backwards compatibility for all drivers equally. > > > > What do you think? > > I'm obviously biased and predisposed to avoid adding extra complexity to > i915 when it's not necessary. We'd have *two* connector properties for > the same thing until the end of time, even if one is an alias for the > other. Yeah just pick one, and implement the others as aliases. Drivers can do the aliases in their atomic_get/set_property functions pretty easily, atomic properties aren't stored anywhere else than decoded (which was done partially to make stuff like this work). Coming up a new property name just so that everyone suffers equally feels silly. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch