Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node

Sergei Shtylyov
2020-04-15T09:15:42Z

Hello!

On 15.04.2020 11:35, H. Nikolaus Schaller wrote:

> From: Jonathan Bakker <xc-racer2@live.ca>
>
> to add support for SGX540 GPU.
>
> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> arch/arm/boot/dts/s5pv210.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
> index 2ad642f51fd9..e7fc709c0cca 100644
> --- a/arch/arm/boot/dts/s5pv210.dtsi
> +++ b/arch/arm/boot/dts/s5pv210.dtsi
> @@ -512,6 +512,21 @@ vic3: interrupt-controller@f2300000 {
> #interrupt-cells = <1>;
> };
>
> + g3d: g3d@f3000000 {

Should be named generically, "gpu@f3000000", according to the DT spec 0.2,
section 2.2.2. It's either "gpu" or "display" TTBOMK...

[...]

MBR, Sergei