From: Lina Iyer <ilina@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Maulik Shah <mkshah@codeaurora.org>
Subject: Re: [PATCH] soc: qcom: cmd-db: Add debugfs dumping file
Date: Wed, 15 Apr 2020 08:17:54 -0600 [thread overview]
Message-ID: <20200415141754.GB3820@codeaurora.org> (raw)
In-Reply-To: <158693222998.105027.13298557609451842017@swboyd.mtv.corp.google.com>
On Tue, Apr 14 2020 at 00:30 -0600, Stephen Boyd wrote:
>Quoting Lina Iyer (2020-04-14 14:50:15)
>> On Mon, Mar 09 2020 at 12:57 -0600, Stephen Boyd wrote:
>> >+ seq_puts(seq, "-------------------------\n");
>> >+
>> >+ ent = rsc_to_entry_header(rsc);
>> >+ for (j = 0; j < le16_to_cpu(rsc->cnt); j++, ent++) {
>> >+ seq_printf(seq, "0x%08x: %*pEp", le32_to_cpu(ent->addr),
>> 0x%05x is what we would have for a resource address.
>
>Sorry I totally missed this because the mail wasn't trimmed at all and
>it was really hard to find the one line that wasn't quoted!
>
Sorry, my bad. Somehow didn't notice the quoting has changed.
>5 vs. 8 sounds OK to me. Send a patch? Or I can do it if you prefer.
Apart from the nit, I think the patch looks good. Feel free to add -
Reviewed-by: Lina Iyer <ilina@codeaurora.org>
Tested-by: Lina Iyer <ilina@codeaurora.org>
next prev parent reply other threads:[~2020-04-15 14:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 18:57 [PATCH] soc: qcom: cmd-db: Add debugfs dumping file Stephen Boyd
2020-04-14 21:50 ` Lina Iyer
2020-04-15 6:30 ` Stephen Boyd
2020-04-15 14:17 ` Lina Iyer [this message]
2020-04-15 19:22 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415141754.GB3820@codeaurora.org \
--to=ilina@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkshah@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox