From: paulmck@kernel.org
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com,
mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org,
Jules Irenge <jbi.octave@gmail.com>,
"Paul E . McKenney" <paulmck@kernel.org>
Subject: [PATCH tip/core/rcu 16/19] rcu: Replace 1 by true
Date: Wed, 15 Apr 2020 10:10:51 -0700 [thread overview]
Message-ID: <20200415171054.9013-16-paulmck@kernel.org> (raw)
In-Reply-To: <20200415171017.GA7821@paulmck-ThinkPad-P72>
From: Jules Irenge <jbi.octave@gmail.com>
Coccinelle reports a warning at use_softirq declaration
WARNING: Assignment of 0/1 to bool variable
The root cause is
use_softirq a variable of bool type is initialised with the integer 1
Replacing 1 with value true solve the issue.
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
kernel/rcu/tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 09ccc29..97c0b47 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -113,7 +113,7 @@ static struct rcu_state rcu_state = {
static bool dump_tree;
module_param(dump_tree, bool, 0444);
/* By default, use RCU_SOFTIRQ instead of rcuc kthreads. */
-static bool use_softirq = 1;
+static bool use_softirq = true;
module_param(use_softirq, bool, 0444);
/* Control rcu_node-tree auto-balancing at boot time. */
static bool rcu_fanout_exact;
--
2.9.5
next prev parent reply other threads:[~2020-04-15 17:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 17:10 [PATCH tip/core/rcu 0/19] Miscellaneous fixes for v5.8 Paul E. McKenney
2020-04-15 17:10 ` [PATCH tip/core/rcu 01/19] rcu: Add KCSAN stubs paulmck
2020-04-15 17:10 ` [PATCH tip/core/rcu 02/19] srcu: " paulmck
2020-04-15 17:10 ` [PATCH tip/core/rcu 03/19] rcu: Mark rcu_state.ncpus to detect concurrent writes paulmck
2020-04-15 17:10 ` [PATCH tip/core/rcu 04/19] rcu: Add *_ONCE() and data_race() to rcu_node ->exp_tasks plus locking paulmck
2020-04-15 17:10 ` [PATCH tip/core/rcu 05/19] rcu: Add READ_ONCE and data_race() to rcu_node ->boost_tasks paulmck
2020-04-15 17:10 ` [PATCH tip/core/rcu 06/19] srcu: Add data_race() to ->srcu_lock_count and ->srcu_unlock_count arrays paulmck
2020-04-15 17:10 ` [PATCH tip/core/rcu 07/19] rcu: Add WRITE_ONCE() to rcu_node ->boost_tasks paulmck
2020-04-15 17:10 ` [PATCH tip/core/rcu 08/19] rcu: Use data_race() for RCU CPU stall-warning prints paulmck
2020-04-15 17:10 ` [PATCH tip/core/rcu 09/19] drm: Make drm_dp_mst_dsc_aux_for_port() safe for old compilers paulmck
2020-04-15 17:10 ` [PATCH tip/core/rcu 10/19] rcu: Expedite first two FQS scans under callback-overload conditions paulmck
2020-04-15 17:10 ` [PATCH tip/core/rcu 11/19] rcu: Fix the (t=0 jiffies) false positive paulmck
2020-04-15 17:10 ` [PATCH tip/core/rcu 12/19] Revert "rculist: Describe variadic macro argument in a Sphinx-compatible way" paulmck
2020-04-15 17:10 ` [PATCH tip/core/rcu 13/19] rcu: Get rid of some doc warnings in update.c paulmck
2020-04-15 17:10 ` [PATCH tip/core/rcu 14/19] rcu: Mark rcu_state.gp_seq to detect more concurrent writes paulmck
2020-04-15 17:10 ` [PATCH tip/core/rcu 15/19] rcu: Replace assigned pointer ret value by corresponding boolean value paulmck
2020-04-15 17:10 ` paulmck [this message]
2020-04-15 17:10 ` [PATCH tip/core/rcu 17/19] rcu: Convert ULONG_CMP_GE() to time_after() for jiffy comparison paulmck
2020-04-15 17:10 ` [PATCH tip/core/rcu 18/19] rcu: Convert rcu_initiate_boost() ULONG_CMP_GE() to time_after() paulmck
2020-04-15 17:10 ` [PATCH tip/core/rcu 19/19] rcu: Convert rcu_nohz_full_cpu() ULONG_CMP_LT() to time_before() paulmck
2020-04-15 17:21 ` [PATCH tip/core/rcu 0/19] Miscellaneous fixes for v5.8 Andrew Morton
2020-04-15 17:32 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415171054.9013-16-paulmck@kernel.org \
--to=paulmck@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=jbi.octave@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox